Merge lp:~rsalveti/goget-ubuntu-touch/touch_serial_adb_push_vivid into lp:goget-ubuntu-touch

Proposed by Ricardo Salveti
Status: Superseded
Proposed branch: lp:~rsalveti/goget-ubuntu-touch/touch_serial_adb_push_vivid
Merge into: lp:goget-ubuntu-touch
Diff against target: 33 lines (+11/-13)
1 file modified
ubuntu-device-flash/touch.go (+11/-13)
To merge this branch: bzr merge lp:~rsalveti/goget-ubuntu-touch/touch_serial_adb_push_vivid
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+257177@code.launchpad.net

This proposal has been superseded by a proposal from 2015-04-22.

Commit message

touch: don't use parallel adb push as that is not so reliable with arale

Description of the change

touch: don't use parallel adb push as that is not so reliable with arale

To post a comment you must log in.

Unmerged revisions

143. By Ricardo Salveti

touch: don't use parallel adb push as that is not so reliable with arale

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-device-flash/touch.go'
2--- ubuntu-device-flash/touch.go 2015-02-10 05:51:08 +0000
3+++ ubuntu-device-flash/touch.go 2015-04-22 21:03:56 +0000
4@@ -306,19 +306,17 @@
5 }
6 for {
7 file := <-files
8- go func() {
9- log.Printf("Start pushing %s to device", file.FilePath)
10- err := adb.Push(file.FilePath, "/cache/recovery/")
11- if err != nil {
12- log.Fatal(err)
13- }
14- err = adb.Push(file.SigPath, "/cache/recovery/")
15- if err != nil {
16- log.Fatal(err)
17- }
18- log.Printf("Done pushing %s to device", file.FilePath)
19- done <- true
20- }()
21+ log.Printf("Start pushing %s to device", file.FilePath)
22+ err := adb.Push(file.FilePath, "/cache/recovery/")
23+ if err != nil {
24+ log.Fatal(err)
25+ }
26+ err = adb.Push(file.SigPath, "/cache/recovery/")
27+ if err != nil {
28+ log.Fatal(err)
29+ }
30+ log.Printf("Done pushing %s to device", file.FilePath)
31+ done <- true
32 }
33 }
34

Subscribers

People subscribed via source and target branches