Code review comment for lp:~rpadovani/webbrowser-app/1351165
Revision history for this message
| Riccardo Padovani (rpadovani) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> At a quick glance, that looks good, thanks for working on this!
>
> I don’t think the onBookmarkRemoved handler in NewTabView.qml is needed: the
> sections should be made dynamic without having to manually add/remove them,
> but that can be addressed separately (for which I filed bug #1389605).
>
> So I would suggest to remove the handler for now, and with that it should be
> good (still need to do some functional testing on a device).
Makes sense, done!