Bookmarks section header in new tab view not updated when a bookmark is added/removed
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app |
Fix Released
|
Medium
|
Riccardo Padovani | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
There are two issues in one:
1. if a user has only one bookmark, she creates a new tab, the new tab view is displayed, if she then switches to another open tab that has this bookmark page open and unstars it from the address bar, and switches back to the new tab view, the bookmark has disappeared, but the bookmarks section header is still there, empty
2. if a user has no bookmarks, she creates a new tab, the new tab view is displayed (with no bookmarks section), if she then switches to another open tab and stars it, then switches back to the new tab view, there is no bookmarks section displayed.
Those two issues boil down to the static nature of the sectionsModel in NewTabView.qml.
Instead of conditionally populating the model when the view is instantiated, the model should always contain the two sections, but the delegate in charge of displaying the sections should be visible only if the corresponding sub-model is not empty.
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 773 lines (+351/-279)6 files modifiedsrc/app/webbrowser/Browser.qml (+59/-59)
src/app/webbrowser/NewTabView.qml (+200/-126)
src/app/webbrowser/UrlsList.qml (+72/-93)
src/app/webbrowser/bookmarks-model.cpp (+3/-1)
src/app/webbrowser/bookmarks-model.h (+2/-0)
tests/unittests/bookmarks-model/tst_BookmarksModelTests.cpp (+15/-0)
| Changed in webbrowser-app: | |
| assignee: | nobody → Riccardo Padovani (rpadovani) |
| status: | Triaged → In Progress |
| tags: | added: newtab |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Fix Released |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Released |
This bug was fixed in the package webbrowser-app - 0.23+15.
---------------
webbrowser-app (0.23+15.
[ CI Train Bot ]
* New rebuild forced.
[ Olivier Tilloy ]
* Actually clear the network cache by deleting the correct set of
files in the correct directory. (LP: #1459956)
* Bump build dependency on liboxideqt-
tests.
* Do not cache favicons on disk when browsing in private mode. (LP:
#1458963)
* Do not try to remove a file that doesn’t exist.
* Pass plain strings to the worker script instead of RegExps. (LP:
#1445673)
* Remove the upstreamcomponents folder, and use components from the
UITK instead. Add autopilot tests for the new tab view.
* Update translation template.
* Updated icon. (LP: #1457424)
[ Riccardo Padovani ]
* New tab view refactoring. (LP: #1371248, #1444023, #1351157,
#1389605, #1442190)
* New tab view refactoring. (LP: #1371248, #1444023, #1351157,
#1389605, #1442190)
-- CI Train Bot <email address hidden> Tue, 02 Jun 2015 14:26:50 +0000