Merge lp:~rpadovani/ubuntu-clock-app/1166264 into lp:ubuntu-clock-app/saucy
Proposed by
Riccardo Padovani
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Nekhelesh Ramananthan | ||||
Approved revision: | 141 | ||||
Merged at revision: | 138 | ||||
Proposed branch: | lp:~rpadovani/ubuntu-clock-app/1166264 | ||||
Merge into: | lp:ubuntu-clock-app/saucy | ||||
Diff against target: |
87 lines (+29/-4) 2 files modified
timer/AnalogTimer.qml (+3/-2) timer/TimerPage.qml (+26/-2) |
||||
To merge this branch: | bzr merge lp:~rpadovani/ubuntu-clock-app/1166264 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Nekhelesh Ramananthan | Approve | ||
Review via email: mp+174458@code.launchpad.net |
Commit message
Added possibility to pause timer
Added reset button to timer
See #1166264
Description of the change
Added possibility to pause timer
Added reset button to timer
See #1166264
To post a comment you must log in.
Nice work. There are some things which need fixing.
It is not required to copy ImageButton.qml from the stopwatch folder to the timer folder. In the timerpage.qml file where you used it, you can just add a statement "import ../stopwatch". This avoid code duplication. Ideally speaking the ImageButton.qml file needs to be moved to the common folder since it is now being used by both Timer and Stopwatch, but this can be addressed in another commit.