Code review comment for lp:~rpadovani/ubuntu-clock-app/1166264

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Nice work. There are some things which need fixing.

It is not required to copy ImageButton.qml from the stopwatch folder to the timer folder. In the timerpage.qml file where you used it, you can just add a statement "import ../stopwatch". This avoid code duplication. Ideally speaking the ImageButton.qml file needs to be moved to the common folder since it is now being used by both Timer and Stopwatch, but this can be addressed in another commit.

review: Needs Fixing

« Back to merge proposal