Code review comment for lp:~rpadovani/reminders-app/improveFirstRun
Revision history for this message
| Riccardo Padovani (rpadovani) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> 86 + if (accounts.count == 1) {
>
> What happens if there are multiple accounts?
Well, that is a problem beyond the scope of this branch.
This branch wants to resolve this workflow on phone:
User launches the app -> No account setted -> Press the button and open the account settings -> Add an account -> The focus auto return to the app (needs to fix bug 1230091 for this) -> Nothing happens
Now, thanks to this fix, we have
User launches the app -> No account setted -> Press the button and open the account settings -> Add an account -> The focus auto return to the app (needs to fix bug 1230091 for this) -> Autologin in the new account.
On phone a user can add only one account before returns to the app, so there is no problem. If more than one account is setted before the start, there is a page that asks to choose which accounts use or, if there was a previous login, it uses last login.
Also, if user sets up wrong account (e.g. Ubuntu One and not Evernote) the focus returns to the app and nothing happens, so there is the button to open (again) system settings
On desktop otherwise a user can add how much accounts want before returns to the app, so I added the if (accounts.count == 1) to login only with the first account added.
@popey, this is a screenshot of actual implementation: http://
https:/