Merge lp:~rpadovani/reminders-app/improveFirstRun into lp:reminders-app

[Riccardo Padovani]

Do autologin if a new account is added in system settings

Improve first run, when there is no account: now, when user returns to the app after the setup of a new account in system settings, his new account is logged.

Thanks to ~mardy for the idea

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:109
http://91.189.93.70:8080/job/reminders-app-ci/271/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2264
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-saucy-amd64-ci/271
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-ci/271

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/271/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

86 + if (accounts.count == 1) {

What happens if there are multiple accounts?

review: Needs Information

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Can we make it a button to launch the online accounts part of system settings, rather than tell the user where to go? We already used to do this with update-manager, and still do it if user tries to install apps without an Ubuntu SSO account configured.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Seems I missed the button! Sorry! As you were.

[Riccardo Padovani (rpadovani)]

> 86 + if (accounts.count == 1) {
>
> What happens if there are multiple accounts?

Well, that is a problem beyond the scope of this branch.
This branch wants to resolve this workflow on phone:

User launches the app -> No account setted -> Press the button and open the account settings -> Add an account -> The focus auto return to the app (needs to fix bug 1230091 for this) -> Nothing happens

Now, thanks to this fix, we have
User launches the app -> No account setted -> Press the button and open the account settings -> Add an account -> The focus auto return to the app (needs to fix bug 1230091 for this) -> Autologin in the new account.

On phone a user can add only one account before returns to the app, so there is no problem. If more than one account is setted before the start, there is a page that asks to choose which accounts use or, if there was a previous login, it uses last login.

Also, if user sets up wrong account (e.g. Ubuntu One and not Evernote) the focus returns to the app and nothing happens, so there is the button to open (again) system settings

On desktop otherwise a user can add how much accounts want before returns to the app, so I added the if (accounts.count == 1) to login only with the first account added.

@popey, this is a screenshot of actual implementation: http://people.ubuntu.com/~rpadovani/touch/reminderNoAccount.png

https://bugs.launchpad.net/unity-mir/+bug/1230091

[Michael Zanetti (mzanetti)]

works for me.

review: Approve

=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml	2014-04-04 06:09:17 +0000
+++ src/app/qml/reminders.qml	2014-04-28 17:56:21 +0000
@@ -30,7 +30,6 @@
 */
 
 MainView {
-
     id: root
 
     // objectName for functional testing purposes (autopilot-qt5)
@@ -93,6 +92,32 @@
         }
     }
 
+    function doLogin() {
+        print("got accounts:", accounts.count)
+        var accountName = accountPreference.accountName;
+        if (accountName) {
+            var i;
+            for (i = 0; i < accounts.count; i++) {
+                if (accounts.get(i, "displayName") == accountName) {
+                    accountService.objectHandle = accounts.get(i, "accountServiceHandle");
+                }
+            }
+        }
+        if (!accountService.objectHandle) {
+            switch (accounts.count) {
+            case 0:
+                PopupUtils.open(noAccountDialog)
+                print("No account available! Please setup an account in the system settings");
+                break;
+            case 1:
+                accountService.objectHandle = accounts.get(0, "accountServiceHandle");
+                break;
+            default:
+                openAccountPage(false);
+            }
+        }
+    }
+
     AccountServiceModel {
         id: accounts
         service: "evernote"
@@ -121,30 +146,8 @@
             height = units.gu(75);
         }
 
-        pagestack.push(rootTabs)
-        print("got accounts:", accounts.count)
-        var accountName = accountPreference.accountName;
-        if (accountName) {
-            var i;
-            for (i = 0; i < accounts.count; i++) {
-                if (accounts.get(i, "displayName") == accountName) {
-                    accountService.objectHandle = accounts.get(i, "accountServiceHandle");
-                }
-            }
-        }
-        if (!accountService.objectHandle) {
-            switch (accounts.count) {
-            case 0:
-                PopupUtils.open(noAccountDialog)
-                print("No account available! Please setup an account in the system settings");
-                break;
-            case 1:
-                accountService.objectHandle = accounts.get(0, "accountServiceHandle");
-                break;
-            default:
-                openAccountPage(false);
-            }
-        }
+        pagestack.push(rootTabs);
+        doLogin();
     }
 
     Connections {
@@ -286,6 +289,17 @@
             objectName: "noAccountDialog"
             title: i18n.tr("No account available")
             text: i18n.tr("Please setup an account in the system settings")
+
+            Connections {
+                target: accounts
+                onCountChanged: {
+                    if (accounts.count == 1) {
+                        PopupUtils.close(noAccount)
+                        doLogin();
+                    }
+                }
+            }
+
             Button {
                 objectName: "openAccountButton"
                 text: i18n.tr("Open account settings")