Code review comment for lp:~rpadovani/reminders-app/1289342

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> > When this happens, the whole NotesList is empty. Why not just paint that
> text
> > in there instead of opening a popup?
>
> In my opinion a popup is better, because the user can't do anything. If we
> modify NotesList we don't disable user's commands, e.g. user can change tab in
> the header

Ok, convinced. A popup it is :)

>
> > Also, below the text, would a button to launch system settings make sense?
>
> Yes, it makes sense at all, but I didn't find a way to launch system settings
> and I preferred to add nothing rather a button that doesn't nothing.
> Do I miss something? There is a way to do this?

It should be possible, yes. I think Qt.openUrlExternally("settings://system/online-accounts") should do.

« Back to merge proposal