Merge lp:~rpadovani/reminders-app/1289342 into lp:reminders-app

[Riccardo Padovani]

Added dialog to inform users if no account is available.

Added dialog to inform users if no account is available. When there will be possibility to launch system settings from the app we will can add a button to open system settings or we will automatically open system settings.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:85
http://91.189.93.70:8080/job/reminders-app-ci/222/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1693
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-saucy-amd64-ci/222
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-ci/222

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/222/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

When this happens, the whole NotesList is empty. Why not just paint that text in there instead of opening a popup?

Also, below the text, would a button to launch system settings make sense?

review: Needs Information

[Riccardo Padovani (rpadovani)]

> When this happens, the whole NotesList is empty. Why not just paint that text
> in there instead of opening a popup?

In my opinion a popup is better, because the user can't do anything. If we modify NotesList we don't disable user's commands, e.g. user can change tab in the header

> Also, below the text, would a button to launch system settings make sense?

Yes, it makes sense at all, but I didn't find a way to launch system settings and I preferred to add nothing rather a button that doesn't nothing.
Do I miss something? There is a way to do this?

[Michael Zanetti (mzanetti)]

> > When this happens, the whole NotesList is empty. Why not just paint that
> text
> > in there instead of opening a popup?
>
> In my opinion a popup is better, because the user can't do anything. If we
> modify NotesList we don't disable user's commands, e.g. user can change tab in
> the header

Ok, convinced. A popup it is :)

>
> > Also, below the text, would a button to launch system settings make sense?
>
> Yes, it makes sense at all, but I didn't find a way to launch system settings
> and I preferred to add nothing rather a button that doesn't nothing.
> Do I miss something? There is a way to do this?

It should be possible, yes. I think Qt.openUrlExternally("settings://system/online-accounts") should do.

[lp:~rpadovani/reminders-app/1289342]

86. By Riccardo Padovani on 2014-03-12

Added button to open accounts settings

[Riccardo Padovani (rpadovani)]

> Ok, convinced. A popup it is :)

Yeah :-)

> It should be possible, yes. I think Qt.openUrlExternally("settings://system
> /online-accounts") should do.

Wow, awesome, thanks! Very useful!

You just forgot a slash, it's settings:///system/online-accounts ;-)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:86
http://91.189.93.70:8080/job/reminders-app-ci/223/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1707
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-saucy-amd64-ci/223
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-ci/223

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/223/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

ack

review: Approve

=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml	2014-02-19 00:07:09 +0000
+++ src/app/qml/reminders.qml	2014-03-12 22:37:24 +0000
@@ -18,6 +18,7 @@
 
 import QtQuick 2.0
 import Ubuntu.Components 0.1
+import Ubuntu.Components.Popups 0.1
 import Ubuntu.Components.ListItems 0.1
 //import "components"
 import "ui"
@@ -134,6 +135,7 @@
         if (!accountService.objectHandle) {
             switch (accounts.count) {
             case 0:
+                PopupUtils.open(noAccountDialog)
                 print("No account available! Please setup an account in the system settings");
                 break;
             case 1:
@@ -274,4 +276,18 @@
             source = "";
         }
     }
+
+    Component {
+        id: noAccountDialog
+        Dialog {
+            id: noAccount
+            title: i18n.tr("No account available")
+            text: i18n.tr("Please setup an account in the system settings")
+            Button {
+                text: i18n.tr("Open account settings")
+                color: UbuntuColors.orange
+                onClicked: Qt.openUrlExternally("settings:///system/online-accounts") 
+            }
+        }
+   }
 }