Merge lp:~rohangarg/apport/fix-for-1282713 into lp:~apport-hackers/apport/trunk
Proposed by
Rohan Garg
Status: | Merged |
---|---|
Merged at revision: | 2783 |
Proposed branch: | lp:~rohangarg/apport/fix-for-1282713 |
Merge into: | lp:~apport-hackers/apport/trunk |
Diff against target: |
17 lines (+7/-0) 1 file modified
kde/apport-kde (+7/-0) |
To merge this branch: | bzr merge lp:~rohangarg/apport/fix-for-1282713 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pitt (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
"introduces another bug which causes apport to launch a dialog saying that it could launch the browser, when in reality it did"
I take it you mean "could NOT launch the browser". I doubt that this is apport itself, presumably it's from xdg-open? Do you have a screenshot of this?
I wonder if we can work around the crash without introducing this confusing dialog. A shot into the blue: What happens if in apport/ui.py "def open_url" you replace the two sys.exit() calls with os._exit()? That'll bypass the Python and sip destructors. I wonder if that crash happens in open_url only, or at a different place.
Thanks!