Code review comment for lp:~rohangarg/apport/fix-for-1282713

Revision history for this message
Rohan Garg (rohangarg) wrote :

> "introduces another bug which causes apport to launch a dialog saying that it
> could launch the browser, when in reality it did"
>
> I take it you mean "could NOT launch the browser". I doubt that this is apport
> itself, presumably it's from xdg-open? Do you have a screenshot of this?
>

Heh, yes, however, from looking at the code [1] I think it's from apport itself,
mandatory screenshot : http://wstaw.org/m/2014/03/31/plasma-desktopVB2282.png

> I wonder if we can work around the crash without introducing this confusing
> dialog. A shot into the blue: What happens if in apport/ui.py "def open_url"
> you replace the two sys.exit() calls with os._exit()? That'll bypass the
> Python and sip destructors. I wonder if that crash happens in open_url only,
> or at a different place.
>

os._exit doesn't help unfortunately

[1] http://bazaar.launchpad.net/~apport-hackers/apport/trunk/view/head:/apport/ui.py#L1129

« Back to merge proposal