Code review comment for ~rodsmith/plainbox-provider-checkbox:fix-arm64-virt

Revision history for this message
Rod Smith (rodsmith) wrote :

Yes, it is necessary. The virtualization test is built to use .tar.gz files for ARM (probably because older pre-EFI environments required a standalone kernel file to boot). If you don't explicitly set a file via KVM_IMAGE, it downloads a .tar.gz file from cloud-images.ubuntu.com. See, for example:

https://certification.canonical.com/hardware/201704-25505/submission/122661/test/380/result/9151571/

This MR, along with the other two that go with it, make minimal changes to the virtualization script and change everything else to make it work with the MAAS server the way it does with cloud-images.ubuntu.com.

It might be possible to engineer it another way, to make it all work with .img files; but my initial attempt at that failed because the virtualization script failed on a raw .img file. Also, if virtualizing in a non-EFI environment really does require a separate kernel file in a tarball, this approach would fail in such an environment.

« Back to merge proposal