Merge ~rodsmith/plainbox-provider-checkbox:fix-arm64-virt into plainbox-provider-checkbox:master

[Rod Smith]

Fix the virtualization script to not double-up the final component when a URL specifies a .tar.gz file, as is used on ARM64 and ARMHF platforms.

[Jeff Lane  (bladernr)]

I'm not sure this is necessary. KVM images all end in .img. The tar.gz and tar.xz images we mirror are all for LXD testing and not covered by the KVM checks.

Where are these .tar.gz images coming from?

review: Needs Information

[Rod Smith (rodsmith)]

Yes, it is necessary. The virtualization test is built to use .tar.gz files for ARM (probably because older pre-EFI environments required a standalone kernel file to boot). If you don't explicitly set a file via KVM_IMAGE, it downloads a .tar.gz file from cloud-images.ubuntu.com. See, for example:

https://certification.canonical.com/hardware/201704-25505/submission/122661/test/380/result/9151571/

This MR, along with the other two that go with it, make minimal changes to the virtualization script and change everything else to make it work with the MAAS server the way it does with cloud-images.ubuntu.com.

It might be possible to engineer it another way, to make it all work with .img files; but my initial attempt at that failed because the virtualization script failed on a raw .img file. Also, if virtualizing in a non-EFI environment really does require a separate kernel file in a tarball, this approach would fail in such an environment.

[Jeff Lane  (bladernr)]

Thanks. It all makes sense now.

review: Approve

diff --git a/bin/virtualization b/bin/virtualization
index b67a5fa..17ab9b7 100755
--- a/bin/virtualization
+++ b/bin/virtualization
@@ -292,7 +292,8 @@ class KVMTest(object):
             if (
                     url.path.endswith('/') or
                     url.path == '' or
-                    not url.path.endswith(".img")
+                    not (url.path.endswith(".img") or
+                         url.path.endswith(".tar.gz"))
                     ):
                 # If we have a relative URL (local copies of official images)
                 # http://192.168.0.1/ or http://192.168.0.1/images/