Merge lp:~rodrigo-moya/ubuntuone-client/add-missing-libsd-api into lp:ubuntuone-client

Proposed by Rodrigo Moya
Status: Merged
Approved by: dobey
Approved revision: 747
Merged at revision: 747
Proposed branch: lp:~rodrigo-moya/ubuntuone-client/add-missing-libsd-api
Merge into: lp:ubuntuone-client
Diff against target: 129 lines (+106/-1)
2 files modified
libsyncdaemon/syncdaemon-daemon.c (+103/-0)
libsyncdaemon/syncdaemon-daemon.h (+3/-1)
To merge this branch: bzr merge lp:~rodrigo-moya/ubuntuone-client/add-missing-libsd-api
Reviewer Review Type Date Requested Status
Stuart Langridge (community) Approve
dobey (community) Approve
Review via email: mp+40939@code.launchpad.net

Commit message

Added missing public files API in SyncdaemonDaemon object

Description of the change

Added missing public files API in SyncdaemonDaemon object

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Stuart Langridge (sil) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (8.8 KiB)

The attempt to merge lp:~rodrigo-moya/ubuntuone-client/add-missing-libsd-api into lp:ubuntuone-client failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.67
checking for automake >= 1.10...
  testing automake-1.11... found 1.11.1
checking for libtool >= 1.5...
  testing libtoolize... found 2.2.6b
checking for intltool >= 0.30...
  testing intltoolize... found 0.41.1
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.25
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.15
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure --enable-gtk-doc --enable-debug ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dep...

Read more...

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There was a problem validating some authors of the branch. Authors must be either one of the listed Launchpad users, or a member of one of the listed teams on Launchpad.

Persons or Teams:

    contributor-agreement-canonical
    ubuntuone-hackers

Unaccepted Authors:

    Rodrigo Moya <email address hidden>

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There was a problem validating some authors of the branch. Authors must be either one of the listed Launchpad users, or a member of one of the listed teams on Launchpad.

Persons or Teams:

    contributor-agreement-canonical
    ubuntuone-hackers

Unaccepted Authors:

    Rodrigo Moya <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libsyncdaemon/Makefile.am'
=== modified file 'libsyncdaemon/syncdaemon-daemon.c'
--- libsyncdaemon/syncdaemon-daemon.c 2010-11-03 10:33:54 +0000
+++ libsyncdaemon/syncdaemon-daemon.c 2010-11-19 09:22:48 +0000
@@ -1068,6 +1068,109 @@
1068}1068}
10691069
1070/**1070/**
1071 * syncdaemon_daemon_publish_file:
1072 * @daemon: A #SyncdaemonDaemon object
1073 * @path: Full path of the file to be published
1074 *
1075 * Publish a file on Ubuntu One. When the file is successfully published, the "file_published"
1076 * signal will be emitted.
1077 *
1078 * Return value: TRUE if successful, FALSE otherwise.
1079 */
1080gboolean
1081syncdaemon_daemon_publish_file (SyncdaemonDaemon *daemon, const gchar *path)
1082{
1083 SyncdaemonMetadata *metadata;
1084 gboolean result = FALSE;
1085
1086 g_return_val_if_fail (SYNCDAEMON_IS_DAEMON (daemon), FALSE);
1087
1088 /* First, retrieve the metadata */
1089 metadata = syncdaemon_daemon_get_metadata (daemon, path, FALSE);
1090 if (metadata != NULL) {
1091 SyncdaemonInterface *interface;
1092
1093 interface = syncdaemon_daemon_get_publicfiles_interface (daemon);
1094 syncdaemon_publicfiles_interface_change_public_access (
1095 SYNCDAEMON_PUBLICFILES_INTERFACE (interface),
1096 syncdaemon_metadata_get_share_id (metadata),
1097 syncdaemon_metadata_get_node_id (metadata),
1098 TRUE);
1099
1100 result = TRUE;
1101
1102 g_object_unref (metadata);
1103 }
1104
1105 return result;
1106}
1107
1108/**
1109 * syncdaemon_daemon_unpublish_file:
1110 * @daemon: A #SyncdaemonDaemon object
1111 * @path: Full path of the file to be unpublished
1112 *
1113 * Unpublish a file from Ubuntu One. When the file is successfully unpublished, the "file_unpublished"
1114 * signal will be emitted.
1115 *
1116 * Return value: TRUE if successful, FALSE otherwise.
1117 */
1118gboolean
1119syncdaemon_daemon_unpublish_file (SyncdaemonDaemon *daemon, const gchar *path)
1120{
1121 SyncdaemonMetadata *metadata;
1122 gboolean result = FALSE;
1123
1124 g_return_val_if_fail (SYNCDAEMON_IS_DAEMON (daemon), FALSE);
1125
1126 /* First, retrieve the metadata */
1127 metadata = syncdaemon_daemon_get_metadata (daemon, path, FALSE);
1128 if (metadata != NULL) {
1129 SyncdaemonInterface *interface;
1130
1131 interface = syncdaemon_daemon_get_publicfiles_interface (daemon);
1132 syncdaemon_publicfiles_interface_change_public_access (
1133 SYNCDAEMON_PUBLICFILES_INTERFACE (interface),
1134 syncdaemon_metadata_get_share_id (metadata),
1135 syncdaemon_metadata_get_node_id (metadata),
1136 FALSE);
1137
1138 result = TRUE;
1139
1140 g_object_unref (metadata);
1141 }
1142
1143 return result;
1144}
1145
1146/**
1147 * syncdaemon_daemon_get_public_files:
1148 * @daemon: A #SyncdaemonDaemon object
1149 *
1150 * Retrieve the list of public files.
1151 *
1152 * Return value: A #GSList of #SyncdaemonFileInfo objects, each of which describes
1153 * a published file for the user. When no longer needed, this list should be
1154 * freed by calling g_slist_free, but the data within the list should never
1155 * be freed, as it belongs to the library.
1156 */
1157GSList *
1158syncdaemon_daemon_get_public_files (SyncdaemonDaemon *daemon)
1159{
1160 SyncdaemonInterface *interface;
1161
1162 g_return_val_if_fail (SYNCDAEMON_IS_DAEMON (daemon), NULL);
1163
1164 interface = syncdaemon_daemon_get_publicfiles_interface (daemon);
1165 if (interface != NULL) {
1166 return syncdaemon_publicfiles_interface_get_public_files (
1167 SYNCDAEMON_PUBLICFILES_INTERFACE (interface));
1168 }
1169
1170 return NULL;
1171}
1172
1173/**
1071 * syncdaemon_daemon_create_share:1174 * syncdaemon_daemon_create_share:
1072 * @daemon: A #SyncdaemonDaemon object1175 * @daemon: A #SyncdaemonDaemon object
1073 * @path: Full path of the folder to be shared1176 * @path: Full path of the folder to be shared
10741177
=== modified file 'libsyncdaemon/syncdaemon-daemon.h'
--- libsyncdaemon/syncdaemon-daemon.h 2010-11-03 10:33:54 +0000
+++ libsyncdaemon/syncdaemon-daemon.h 2010-11-19 09:22:48 +0000
@@ -124,7 +124,9 @@
124void syncdaemon_daemon_unsubscribe_folder (SyncdaemonDaemon *daemon, const gchar *path);124void syncdaemon_daemon_unsubscribe_folder (SyncdaemonDaemon *daemon, const gchar *path);
125125
126/* Public files operations */126/* Public files operations */
127/* FIXME: need nautilus-refactor branch landed first */127gboolean syncdaemon_daemon_publish_file (SyncdaemonDaemon *daemon, const gchar *path);
128gboolean syncdaemon_daemon_unpublish_file (SyncdaemonDaemon *daemon, const gchar *path);
129GSList *syncdaemon_daemon_get_public_files (SyncdaemonDaemon *daemon);
128130
129/* Shares operations */131/* Shares operations */
130void syncdaemon_daemon_create_share (SyncdaemonDaemon *daemon,132void syncdaemon_daemon_create_share (SyncdaemonDaemon *daemon,

Subscribers

People subscribed via source and target branches