Code review comment for lp:~rodrigo-moya/ubuntuone-client/add-missing-libsd-api

The attempt to merge lp:~rodrigo-moya/ubuntuone-client/add-missing-libsd-api into lp:ubuntuone-client failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.67
checking for automake >= 1.10...
  testing automake-1.11... found 1.11.1
checking for libtool >= 1.5...
  testing libtoolize... found 2.2.6b
checking for intltool >= 0.30...
  testing intltoolize... found 0.41.1
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.25
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.15
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure --enable-gtk-doc --enable-debug ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for ar... ar
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.19... yes
checking whether NLS is requested... yes
checking for intltool >= 0.40.0... 0.41.1 found
checking for intltool-update... /usr/bin/intltool-update
checking for intltool-merge... /usr/bin/intltool-merge
checking for intltool-extract... /usr/bin/intltool-extract
checking for xgettext... /usr/bin/xgettext
checking for msgmerge... /usr/bin/msgmerge
checking for msgfmt... /usr/bin/msgfmt
checking for gmsgfmt... /usr/bin/msgfmt
checking for perl... /usr/bin/perl
checking for perl >= 5.8.1... 5.10.1
checking for XML::Parser... ok
checking for lndir... /usr/bin/lndir
checking for icontool-render... /usr/bin/icontool-render
checking development series build... no
checking for a Python interpreter with version >= 2.5... python
checking for python... /usr/bin/python
checking for python version... 2.6
checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.6/dist-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.6/dist-packages
checking for pycentral... no
checking for ubuntu-sso-client... using system path
checking for ubuntuone-storage-protocol... using system path
checking for NAUTILUS... yes
checking for DBUS... yes
checking whether to build contacts grid or list view... list
checking for gtkdoc-check... /usr/bin/gtkdoc-check
checking for gtkdoc-rebase... /usr/bin/gtkdoc-rebase
checking for gtkdoc-mkpdf... /usr/bin/gtkdoc-mkpdf
checking whether to build gtk-doc documentation... yes
checking for gobject-introspection... yes
checking if gobject-introspection requires new options... yes
checking for glib-genmarshal... /usr/bin/glib-genmarshal
checking for SETTINGS_PLUGIN... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating data/Makefile
config.status: creating libsyncdaemon/Makefile
config.status: creating libsyncdaemon/libsyncdaemon-1.0.pc
config.status: creating nautilus/Makefile
config.status: creating po/Makefile.in
config.status: creating gsd-plugin/Makefile
config.status: creating docs/Makefile
config.status: creating docs/reference/Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
config.status: executing po/stamp-it commands
Now type `make' to compile ubuntuone-client
make: Entering directory `/var/cache/tarmac/ubuntuone-client/trunk/libsyncdaemon'
/usr/bin/glib-genmarshal syncdaemon-marshal.list --header --prefix=_syncdaemon_marshal > syncdaemon-marshal.h
/usr/bin/glib-genmarshal syncdaemon-marshal.list --body --prefix=_syncdaemon_marshal > syncdaemon-marshal.c
  CC syncdaemon-marshal.lo
  CC syncdaemon-authentication.lo
  CC syncdaemon-daemon.lo
make: Leaving directory `/var/cache/tarmac/ubuntuone-client/trunk/libsyncdaemon'

configure.ac:14: installing `./config.guess'
configure.ac:14: installing `./config.sub'
configure.ac:7: installing `./install-sh'
configure.ac:7: installing `./missing'
gsd-plugin/Makefile.am: installing `./depcomp'
cc1: warnings being treated as errors
syncdaemon-daemon.c: In function 'syncdaemon_daemon_publish_file':
syncdaemon-daemon.c:1089:11: error: assignment from incompatible pointer type
syncdaemon-daemon.c:1096:4: error: passing argument 1 of 'syncdaemon_metadata_get_share_id' from incompatible pointer type
syncdaemon-metadata.h:57:21: note: expected 'struct SyncdaemonMetadata *' but argument is of type 'struct SyncdaemonInterface *'
syncdaemon-daemon.c:1097:4: error: passing argument 1 of 'syncdaemon_metadata_get_node_id' from incompatible pointer type
syncdaemon-metadata.h:59:21: note: expected 'struct SyncdaemonMetadata *' but argument is of type 'struct SyncdaemonInterface *'
syncdaemon-daemon.c: In function 'syncdaemon_daemon_unpublish_file':
syncdaemon-daemon.c:1127:11: error: assignment from incompatible pointer type
syncdaemon-daemon.c:1134:4: error: passing argument 1 of 'syncdaemon_metadata_get_share_id' from incompatible pointer type
syncdaemon-metadata.h:57:21: note: expected 'struct SyncdaemonMetadata *' but argument is of type 'struct SyncdaemonInterface *'
syncdaemon-daemon.c:1135:4: error: passing argument 1 of 'syncdaemon_metadata_get_node_id' from incompatible pointer type
syncdaemon-metadata.h:59:21: note: expected 'struct SyncdaemonMetadata *' but argument is of type 'struct SyncdaemonInterface *'
make: *** [syncdaemon-daemon.lo] Error 1