Generally this seems ok. It seems your basic choice was not to break links by email, but to fake an email by using the username.
I would guess this is unlikely to collide, so it seems okay.
You do have a typo, though: "chanch" => "chance".
Also, a test would be nice, though I realize the bzr-stats code is rather un-tested.
Hmm.... I'd really like to vote "Approve pending updates" but it seems LP only gives me the ability to Approve, Reject or Abstain... :(
« Back to merge proposal
Generally this seems ok. It seems your basic choice was not to break links by email, but to fake an email by using the username.
I would guess this is unlikely to collide, so it seems okay.
You do have a typo, though:
"chanch" => "chance".
Also, a test would be nice, though I realize the bzr-stats code is rather un-tested.
Hmm.... I'd really like to vote "Approve pending updates" but it seems LP only gives me the ability to Approve, Reject or Abstain... :(