bzr-stats

Merge lp:~rockstar/bzr-stats/import-branch-support into lp:bzr-stats

  1. import-branch-support
  2. Merge into trunk
Proposed by Paul Hummer
Status: Merged
Merged at revision: not available
Proposed branch: lp:~rockstar/bzr-stats/import-branch-support
Merge into: lp:bzr-stats
To merge this branch: bzr merge lp:~rockstar/bzr-stats/import-branch-support
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) Approve
John A Meinel A good one Approve
Review via email: mp+574@code.launchpad.net
To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

Generally this seems ok. It seems your basic choice was not to break links by email, but to fake an email by using the username.

I would guess this is unlikely to collide, so it seems okay.

You do have a typo, though:
"chanch" => "chance".

Also, a test would be nice, though I realize the bzr-stats code is rather un-tested.

Hmm.... I'd really like to vote "Approve pending updates" but it seems LP only gives me the ability to Approve, Reject or Abstain... :(

review: Approve
lp:~rockstar/bzr-stats/import-branch-support updated
25. By Paul Hummer

Fixed a typo per review

Revision history for this message
Paul Hummer (rockstar) wrote :

I completely forgot about this branch until I was doing some debugging. I've fixed the typo. I also did some other work on another bzr-stats branch that I'll be submitting later.

Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Subscribers

People subscribed via source and target branches

to all changes: