Merge lp:~rhettg/gearmand/no-unique into lp:gearmand/1.0
Proposed by
rhettg
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~rhettg/gearmand/no-unique |
Merge into: | lp:gearmand/1.0 |
Diff against target: |
102 lines (+46/-0) 4 files modified
libgearman-server/job.c (+11/-0) libgearman/constants.h (+1/-0) tests/sqlite_test.c (+33/-0) tests/sqlite_test.rec (+1/-0) |
To merge this branch: | bzr merge lp:~rhettg/gearmand/no-unique |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gearman-developers | Pending | ||
Review via email: mp+16603@code.launchpad.net |
To post a comment you must log in.
Queuing background jobs without a unique key is fundamentally broken with all types of persistence.
This leads to confusing behavior where jobs are accepted sometimes, but refused other times because of the underlying schema of the persistence layer.
You can see this behavior by using the special (and undocumented ?) "-" unique key, as well as the empty string "".
This change modifies the behavior to require a unique key when using persistence and providing a useful error message.