Code review comment for lp:~rharding/charmworld/novel-charmtools

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM, thanks

https://codereview.appspot.com/22540043/diff/1/charmworld/jobs/ingest.py
File charmworld/jobs/ingest.py (right):

https://codereview.appspot.com/22540043/diff/1/charmworld/jobs/ingest.py#newcode352
charmworld/jobs/ingest.py:352: settings['proof.port'],
Where does proof.port come from? I've looked but don't see it (which is
why I'm glad you did this part).

https://codereview.appspot.com/22540043/diff/1/charmworld/testing/data/sample_charm/production_overrides.ini
File charmworld/testing/data/sample_charm/production_overrides.ini
(right):

https://codereview.appspot.com/22540043/diff/1/charmworld/testing/data/sample_charm/production_overrides.ini#newcode8
charmworld/testing/data/sample_charm/production_overrides.ini:8:
proof.port = 6543
Oh, looky, there it is!

https://codereview.appspot.com/22540043/

« Back to merge proposal