Merge lp:~rharding/charmworld/novel-charmtools into lp:charmworld
Status: | Merged |
---|---|
Approved by: | Richard Harding |
Approved revision: | 450 |
Merged at revision: | 450 |
Proposed branch: | lp:~rharding/charmworld/novel-charmtools |
Merge into: | lp:charmworld |
Diff against target: |
88 lines (+15/-5) 5 files modified
charmworld/jobs/ingest.py (+6/-1) charmworld/jobs/tests/test_ingest.py (+3/-3) charmworld/testing/data/sample_charm/production_overrides.ini (+1/-0) default.ini (+4/-0) requirements.txt (+1/-1) |
To merge this branch: | bzr merge lp:~rharding/charmworld/novel-charmtools |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Gui Bot | continuous-integration | Approve | |
Charmworld Developers | Pending | ||
Review via email: mp+194257@code.launchpad.net |
Commit message
Use forked charm-tools to allow tweaking endpoint.
- The download-cache is updated with the forked build
- Tweaks to force ingest to look at localhost:port to run
- Added the port to the config and updated the production overrides so that
production talks to itself without egress filter issues.
- Update tests for the extra kwarg endpoint.
Note: You cannot ingest bundles without a running instance. This means
to ingest bundles in local dev you must also `make run`.
https:/
R=bac
Description of the change
Use forked charm-tools to allow tweaking endpoint.
- The download-cache is updated with the forked build
- Tweaks to force ingest to look at localhost:port to run
- Added the port to the config and updated the production overrides so that
production talks to itself without egress filter issues.
- Update tests for the extra kwarg endpoint.
Note: You cannot ingest bundles without a running instance. This means
to ingest bundles in local dev you must also `make run`.
Reviewers: mp+194257_ code.launchpad. net,
Message:
Please take a look.
Description:
Use forked charm-tools to allow tweaking endpoint.
- The download-cache is updated with the forked build
- Tweaks to force ingest to look at localhost:port to run
- Added the port to the config and updated the production overrides so
that
production talks to itself without egress filter issues.
- Update tests for the extra kwarg endpoint.
Note: You cannot ingest bundles without a running instance. This means
to ingest bundles in local dev you must also `make run`.
https:/ /code.launchpad .net/~rharding/ charmworld/ novel-charmtool s/+merge/ 194257
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/22540043/
Affected files (+17, -5 lines): jobs/ingest. py jobs/tests/ test_ingest. py testing/ data/sample_ charm/productio n_overrides. ini
A [revision details]
M charmworld/
M charmworld/
M charmworld/
M default.ini
M requirements.txt
Index: [revision details] 20131106211543- mdy7zo9iywzec4m m
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-
+New revision: <email address hidden>
Index: default.ini
=== modified file 'default.ini'
--- default.ini 2013-09-04 10:26:28 +0000
+++ default.ini 2013-11-06 22:54:45 +0000
@@ -58,6 +58,10 @@
# text)
days_of_revisions = 30
+# The port to hit up for proof. This should match up the server:main port
+# below.
+proof.port = 2464
+
[server:main]
use = egg:Paste#http
host = 0.0.0.0
Index: requirements.txt tools== 1.1.2-charmworl d
=== modified file 'requirements.txt'
--- requirements.txt 2013-11-05 00:24:42 +0000
+++ requirements.txt 2013-11-06 21:30:01 +0000
@@ -3,7 +3,7 @@
Beaker==1.6.4
bzr==2.5.1
Chameleon==2.5.1
-charm-tools==1.1.2
+charm-
Cheetah==2.4.4
colander==0.9.9
configobj==4.7.2
Index: charmworld/ jobs/ingest. py jobs/ingest. py' jobs/ingest. py 2013-11-05 19:56:37 +0000 jobs/ingest. py 2013-11-06 22:54:45 +0000
=== modified file 'charmworld/
--- charmworld/
+++ charmworld/
@@ -347,7 +347,12 @@
@staticmethod basket_ file, is_bundle=True) 3/bundle/ proof". format( 'proof. port'], ERROR_CODE
def proof(basket_file):
- lint, err = proof.proof(
+ endpoint = "http://{}:{}/api/
+ 'localhost',
+ settings[
+ )
+ lint, err = proof.proof(
+ basket_file, is_bundle=True, endpoint=endpoint)
return lint, err >= CHARMTOOL_
def run(self, basket_data):
Index: charmworld/ jobs/tests/ test_ingest. py jobs/tests/ test_ingest. py' jobs/tests/ test_ingest. py 2013-11-05 18:57:10 +0000 jobs/tests/ test_ingest. py 2013-11-06 23:04:32 +0000
job. setup(self. db) charmtools. proof.proof' ,
self.assertEqua l(True, err)
=== modified file 'charmworld/
--- charmworld/
+++ charmworld/
@@ -608,7 +608,7 @@
job = UpdateBundleJob()
with patch('
- lambda path, is_bundle: ([], 200)):
+ lambda path, is_bundle, endpoint: ([], 200)):
lint, err = job.proof('dummy')
@@ -616,...