Merge lp:~renukaapte/nova/lp745340 into lp:~citrix-openstack/nova/xenapi
Proposed by
Renuka Apte
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Armando Migliaccio | ||||
Approved revision: | 928 | ||||
Merge reported by: | Armando Migliaccio | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~renukaapte/nova/lp745340 | ||||
Merge into: | lp:~citrix-openstack/nova/xenapi | ||||
Diff against target: |
78 lines (+23/-21) 2 files modified
Authors (+1/-0) nova/virt/xenapi/volume_utils.py (+22/-21) |
||||
To merge this branch: | bzr merge lp:~renukaapte/nova/lp745340 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Armando Migliaccio (community) | Approve | ||
Vish Ishaya (community) | Approve | ||
termie (community) | Approve | ||
Review via email: mp+57399@code.launchpad.net |
To post a comment you must log in.
You've got a few places with funky indents, looks like you just need to update the indentation of some of the lines around the lines you've changed.
Just a suggestion but my favorite way of dealing with these split up execute calls is:
44 + (r, _e) = utils.execute( 'sudo', 'iscsiadm', '-m', 'discovery',
45 + '-t', 'sendtargets', '-p', volume_ref['host'])
Is like this:
(r, _e) = utils.execute( 'sudo', 'iscsiadm',
'-m' , 'discovery',
'-t' , 'sendtargets',
'-p' , volume_ref['host'])
I don't really understand your -vol- -volume-- changes, but I'll take your word for it that -vol- was incorrect.