Code review comment for lp:~renukaapte/nova/lp745340

Revision history for this message
termie (termie) wrote :

You've got a few places with funky indents, looks like you just need to update the indentation of some of the lines around the lines you've changed.

Just a suggestion but my favorite way of dealing with these split up execute calls is:

44 + (r, _e) = utils.execute('sudo', 'iscsiadm', '-m', 'discovery',
45 + '-t', 'sendtargets', '-p', volume_ref['host'])

Is like this:

(r, _e) = utils.execute('sudo', 'iscsiadm',
                        '-m', 'discovery',
                        '-t', 'sendtargets',
                        '-p', volume_ref['host'])

I don't really understand your -vol- -volume-- changes, but I'll take your word for it that -vol- was incorrect.

review: Needs Fixing

« Back to merge proposal