Code review comment for lp:~renatofilho/address-book-service/fix-1419854

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> It works but there are improvements that should be made to the UI.
>
> 1) If I select all from address-book and press the checkmark (in picker mode)
> or Share in normal selection mode, the screen switches back to main contact
> view and stays there for a while with no feedback, then the content-hub peer
> picker shows (or returns to calling app). We should show a spinner or some
> kind of feedback while the waiting for the export operation to complete and we
> shouldn't go back to the main contacts view at all. Should go from selection
> page directly to peer picker or directly back to app that called it.
Fixed on address-book-app MR: https://code.launchpad.net/~renatofilho/address-book-app/fix-1419854/+merge/249632
>
> 2) when we enter selection mode on the app, the header should say "Select".
> Currently it's blank.

This was a designer decision they asked us to remove the title while in selection mode. This was done some time ago.

« Back to merge proposal