Merge lp:~renatofilho/address-book-service/fix-1419854 into lp:address-book-service

[Renato Araujo Oliveira Filho]

Update fetch by id with all contacts in the end of the query.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:151
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/323/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/7
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/7/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/7/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1305
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/601/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1303
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1303/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17976
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/711/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/323/rebuild

review: Needs Fixing (continuous-integration)

[Renato Araujo Oliveira Filho (renatofilho)]

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? NO UI CHANGED

If you changed UI labels, did you update the pot file? NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGED

[Bill Filler (bfiller)]

It works but there are improvements that should be made to the UI.

1) If I select all from address-book and press the checkmark (in picker mode) or Share in normal selection mode, the screen switches back to main contact view and stays there for a while with no feedback, then the content-hub peer picker shows (or returns to calling app). We should show a spinner or some kind of feedback while the waiting for the export operation to complete and we shouldn't go back to the main contacts view at all. Should go from selection page directly to peer picker or directly back to app that called it.

2) when we enter selection mode on the app, the header should say "Select". Currently it's blank.

review: Needs Fixing

[Renato Araujo Oliveira Filho (renatofilho)]

> It works but there are improvements that should be made to the UI.
>
> 1) If I select all from address-book and press the checkmark (in picker mode)
> or Share in normal selection mode, the screen switches back to main contact
> view and stays there for a while with no feedback, then the content-hub peer
> picker shows (or returns to calling app). We should show a spinner or some
> kind of feedback while the waiting for the export operation to complete and we
> shouldn't go back to the main contacts view at all. Should go from selection
> page directly to peer picker or directly back to app that called it.
Fixed on address-book-app MR: https://code.launchpad.net/~renatofilho/address-book-app/fix-1419854/+merge/249632
>
> 2) when we enter selection mode on the app, the header should say "Select".
> Currently it's blank.

This was a designer decision they asked us to remove the title while in selection mode. This was done some time ago.

=== modified file 'contacts/qcontactfetchbyidrequest-data.cpp'
--- contacts/qcontactfetchbyidrequest-data.cpp	2014-07-01 14:43:55 +0000
+++ contacts/qcontactfetchbyidrequest-data.cpp	2015-02-11 15:59:02 +0000
@@ -44,8 +44,19 @@
 
 void QContactFetchByIdRequestData::updateRequest(QContactAbstractRequest::State state, QContactManager::Error error, QMap<int, QContactManager::Error> errorMap)
 {
+    QList<QtContacts::QContact> result;
+    // send all results only in the finished state, this will avoid a contact update in every updateContactFetchRequest
+    switch(state)
+    {
+    case QContactAbstractRequest::FinishedState:
+        result = m_allResults;
+        break;
+    default:
+        result = m_result;
+    }
+
     QContactManagerEngine::updateContactFetchByIdRequest(static_cast<QContactFetchByIdRequest*>(m_request.data()),
-                                                         m_result,
+                                                         result,
                                                          error,
                                                          errorMap,
                                                          state);