Ubuntu
update-notifier package

Code review comment for ~renanrodrigo/ubuntu/+source/update-notifier:respect-phasing-xenial

  1. Git
  2. lp:~renanrodrigo/ubuntu/+source/update-notifier
  3. respect-phasing-xenial
  4. Merge into ubuntu/xenial-devel
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

The code review was performed for the development branch at https://code.launchpad.net/~renanrodrigo/update-notifier/+git/update-notifier/+merge/438009.

The range diff is sane compared to the development changes. The only diff is the version/target series in the changelog.

The package builds fine and the DEP8 test suite is passing.

LGTM

I did split the logical changes from the changelog ones here though.

Thanks!

Uploaded:

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading update-notifier_3.168.20.dsc: done.
  Uploading update-notifier_3.168.20.tar.xz: done.
  Uploading update-notifier_3.168.20_source.buildinfo: done.
  Uploading update-notifier_3.168.20_source.changes: done.
Successfully uploaded packages.

review: Approve

« Back to merge proposal