Merge ~renanrodrigo/ubuntu/+source/update-notifier:respect-phasing-xenial into ubuntu/+source/update-notifier:ubuntu/xenial-devel
Proposed by
Renan Rodrigo
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Renan Rodrigo | ||||
Merged at revision: | 01a2b1ed0706cb9098df92c04328663bdb5c933e | ||||
Proposed branch: | ~renanrodrigo/ubuntu/+source/update-notifier:respect-phasing-xenial | ||||
Merge into: | ubuntu/+source/update-notifier:ubuntu/xenial-devel | ||||
Diff against target: |
71 lines (+32/-6) 2 files modified
data/apt_check.py (+26/-6) debian/changelog (+6/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Athos Ribeiro (community) | Approve | ||
git-ubuntu import | Pending | ||
Review via email: mp+438015@code.launchpad.net |
Description of the change
isolate creation of the esm apt cache in apt-check
create a separate function to configure apt_pkg, create the esm cache
and reinitialize the default configuration
To post a comment you must log in.
The code review was performed for the development branch at https:/ /code.launchpad .net/~renanrodr igo/update- notifier/ +git/update- notifier/ +merge/ 438009.
The range diff is sane compared to the development changes. The only diff is the version/target series in the changelog.
The package builds fine and the DEP8 test suite is passing.
LGTM
I did split the logical changes from the changelog ones here though.
Thanks!
Uploaded:
Uploading to ubuntu (via ftp to upload.ubuntu.com): notifier_ 3.168.20. dsc: done. notifier_ 3.168.20. tar.xz: done. notifier_ 3.168.20_ source. buildinfo: done. notifier_ 3.168.20_ source. changes: done.
Uploading update-
Uploading update-
Uploading update-
Uploading update-
Successfully uploaded packages.