Code review comment for lp:~rconradharris/nova/lp794672

Revision history for this message
Dan Prince (dan-prince) wrote :

> Dan--
>
> > Do we want to maintain backwards compatibility with the old
> glance_host/glance_port flags as well?
>
> Good question.
>
> My preference is to just rip the band-aid off, make the change to using a
> list, and have one correct way going forward. Post-diablo it will be much
> harder, I think, to deprecate glance_host and glance_port.

Thanks Rick. I agree.

After a bit of pondering I think I actually like the single --glance_api_servers flag better anyway.

Regarding some of the other comments I would say that nothing you've done here prevents anyone from using a load balancer. Using a load balancer is certainly a good option. However the Glance image service is unique in that it is bandwidth intensive and providing a simple random choice option within nova seems reasonable to me. Sounds like a practical approach to me.

Good work!

review: Approve

« Back to merge proposal