Code review comment for lp:~rconradharris/nova/lp794672

Revision history for this message
Rick Harris (rconradharris) wrote :

Brian Waldon--

> This is adding a very simple load-balancing implementation that, to be useful, needs to be very well thought out. For example, what happens when one of your glance servers is down

This is just to facilitate load-testing. The recommendation, as before, stands: use a real load-balancer in prod.

> As a side note, I couldn't get the flag set up correctly. What should that look like?

Hmm, I'll look into that.

Dan--

> Do we want to maintain backwards compatibility with the old glance_host/glance_port flags as well?

Good question.

My preference is to just rip the band-aid off, make the change to using a list, and have one correct way going forward. Post-diablo it will be much harder, I think, to deprecate glance_host and glance_port.

« Back to merge proposal