VMBuilder

Code review comment for lp:~rcj/vmbuilder/jenkins_kvm_lp1479165

  1. jenkins_kvm_lp1479165
  2. Merge into jenkins_kvm
Revision history for this message
Ben Howard (darkmuggle-deactivatedaccount) wrote :

This is safe. WALinuxAgent includes a cloud-init config dropped to /etc/cloud/cloud.cfg.d/91_walinuxagent.cfg that defines the datasource. Since cloud-init uses /etc/cloud/cloud.cfg.d/90-dpkg.cfg as part of the debconf selections, the mere presence of WALinuxAgent moots this code.

In fact, WALinuxAgent back to 12.04 has the same code. If anything, I would _drop_ the entire section.

See: https://git.launchpad.net/~utlemming/+git/lp1479165/diff/

review: Approve (peer)

« Back to merge proposal