Merge lp:~raoul-snyman/openlp/bug-812289 into lp:openlp

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 1757
Proposed branch: lp:~raoul-snyman/openlp/bug-812289
Merge into: lp:openlp
Diff against target: 30 lines (+6/-3)
2 files modified
openlp/plugins/songs/forms/editsongform.py (+1/-1)
openlp/plugins/songs/lib/mediaitem.py (+5/-2)
To merge this branch: bzr merge lp:~raoul-snyman/openlp/bug-812289
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+76653@code.launchpad.net

This proposal supersedes a proposal from 2011-09-22.

Commit message

Fixed bug #812289. Forced the mediaitem to get the QListWidgetItem from the list again.

Description of the change

Fixed bug #812289. Forced the mediaitem to get the QListWidgetItem from the list again.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/plugins/songs/forms/editsongform.py'
--- openlp/plugins/songs/forms/editsongform.py 2011-09-04 12:04:44 +0000
+++ openlp/plugins/songs/forms/editsongform.py 2011-09-22 20:44:38 +0000
@@ -682,7 +682,7 @@
682 text = unicode(self.songBookComboBox.currentText())682 text = unicode(self.songBookComboBox.currentText())
683 if item == 0 and text:683 if item == 0 and text:
684 temp_song_book = text684 temp_song_book = text
685 self.mediaitem.song_maintenance_form.exec_()685 self.mediaitem.songMaintenanceForm.exec_()
686 self.loadAuthors()686 self.loadAuthors()
687 self.loadBooks()687 self.loadBooks()
688 self.loadTopics()688 self.loadTopics()
689689
=== modified file 'openlp/plugins/songs/lib/mediaitem.py'
--- openlp/plugins/songs/lib/mediaitem.py 2011-09-16 08:15:37 +0000
+++ openlp/plugins/songs/lib/mediaitem.py 2011-09-22 20:44:38 +0000
@@ -428,8 +428,11 @@
428428
429 def generateSlideData(self, service_item, item=None, xmlVersion=False,429 def generateSlideData(self, service_item, item=None, xmlVersion=False,
430 remote=False):430 remote=False):
431 log.debug(u'generateSlideData (%s:%s)' % (service_item, item))431 log.debug(u'generateSlideData: %s, %s, %s' % (service_item, item, self.remoteSong))
432 item_id = self._getIdOfItemToGenerate(item, self.remoteSong)432 # The ``None`` below is a workaround for bug #812289 - I think that Qt
433 # deletes the item somewhere along the line because the user is taking
434 # so long to update their item (or something weird like that).
435 item_id = self._getIdOfItemToGenerate(None, self.remoteSong)
433 service_item.add_capability(ItemCapabilities.CanEdit)436 service_item.add_capability(ItemCapabilities.CanEdit)
434 service_item.add_capability(ItemCapabilities.CanPreview)437 service_item.add_capability(ItemCapabilities.CanPreview)
435 service_item.add_capability(ItemCapabilities.CanLoop)438 service_item.add_capability(ItemCapabilities.CanLoop)