Merge lp:~raoul-snyman/openlp/bug-1386896 into lp:openlp
Status: | Merged |
---|---|
Merged at revision: | 2435 |
Proposed branch: | lp:~raoul-snyman/openlp/bug-1386896 |
Merge into: | lp:openlp |
Diff against target: |
94 lines (+47/-3) 3 files modified
openlp/core/ui/media/vlcplayer.py (+2/-1) openlp/core/ui/settingsform.py (+17/-2) tests/functional/openlp_core_ui/test_settingsform.py (+28/-0) |
To merge this branch: | bzr merge lp:~raoul-snyman/openlp/bug-1386896 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Bentley | Approve | ||
Review via email: mp+240187@code.launchpad.net |
Description of the change
Two fixes:
- Fix bug #1386896 by catching the OSError on Mac OS X and just ignoring it
- Found a potential bug where the settings form was canceled, with one or more inactive plugins
- Wrote a test for the above settings form bug
Add this to your merge proposal:
-------
lp:~raoul-snyman/openlp/bug-1386896 (revision 2435)
[SUCCESS] http://
[SUCCESS] http://
[SUCCESS] http://
[SUCCESS] http://
[SUCCESS] http://
[SUCCESS] http://
[SUCCESS] http://