lp:~raoul-snyman/openlp/bug-1386896
- Get this branch:
- bzr branch lp:~raoul-snyman/openlp/bug-1386896
Branch merges
- Tim Bentley: Approve
-
Diff: 94 lines (+47/-3)3 files modifiedopenlp/core/ui/media/vlcplayer.py (+2/-1)
openlp/core/ui/settingsform.py (+17/-2)
tests/functional/openlp_core_ui/test_settingsform.py (+28/-0)
Related bugs
Bug #1386896: OpenLP fails to open when VLC is not installed on Mac OS X | High | Fix Released |
Related blueprints
Branch information
Recent revisions
- 2435. By Raoul Snyman
-
Two fixes:
- Fix bug #1386896 by catching the OSError on Mac OS X and just ignoring it
- Found a potential bug where the settings form was canceled, with one or more inactive plugins
- Wrote a test for the above settings form bug - 2431. By Tomas Groth
-
Various small bugfixes:
- Fixes adding of images and media to the media manager. Copied from lp:~rafaellerm/openlp/media_import_fix
- Fix for another occurrence of bug #1296574. Copied from lp:~erik-lundin/openlp/bug-1296574
- Fixed a tiny glitch, remove author button became always disabled even if not needed to. Copied from lp:~mahfiaz/openlp/author-delete-button-not-active-in-edit-dialog
- Remove prints in http_router
- Change filename encoding in PptviewDocument to only apply to local variable, to avoid backtrace. - 2429. By Raoul Snyman
-
[fix #1385438] Make list widget items select tab pages via user data rather than just their position.
- 2428. By Raoul Snyman
-
Fix up the look and feel of the wizards after I messed it up with my changes for OS X
Added and updated tests:
- Refactored FirstTimeForm to use an initalise() method, in order to be more testable
- Rewrote FTW tests to test initialise()
- Refactored TestMixin get_application() to setup_application() since it doesn't actually return an application object
- Refactored ListPreviewWidget to make it more testable
- Wrote tests for ListPreviewWidget
- Refactored FormattingTagsForm somewhat
- Updated FormattingTagsForm tests
Updated setup.py with some Python3 changes.
Merged HEAD
Forgot to catch the cancel_wizard_text refactor
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:openlp