Code review comment for lp:~ralsina/ubuntuone-windows-installer/put-in-autostart

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

ubuntuone_installer/gui/qt/utils/tests/test_windows.py:
    96: [C0301] Line too long (89/79)
    97: [C0301] Line too long (148/79)
    73: [C0103, FakeRegistry.ConnectRegistry] Invalid name "ConnectRegistry" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown))
    73: [C0111, FakeRegistry.ConnectRegistry] Missing docstring
    77: [C0103, FakeRegistry.OpenKey] Invalid name "OpenKey" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown))
    77: [C0111, FakeRegistry.OpenKey] Missing docstring
    81: [C0103, FakeRegistry.CloseKey] Invalid name "CloseKey" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown))
    81: [C0111, FakeRegistry.CloseKey] Missing docstring
    84: [C0103, FakeRegistry.QueryValueEx] Invalid name "QueryValueEx" (should match ([a-z_][a-z0-9_]{2,79}$|setUp|tearDown))
    84: [C0111, FakeRegistry.QueryValueEx] Missing docstring
    85: [W0201, FakeRegistry.QueryValueEx] Attribute 'query_args' defined outside __init__
    78: [W0201, FakeRegistry.OpenKey] Attribute 'openkey_args' defined outside __init__
    82: [W0201, FakeRegistry.CloseKey] Attribute 'closekey_args' defined outside __init__
    74: [W0201, FakeRegistry.ConnectRegistry] Attribute 'connect_args' defined outside __init__
    27: [W0611] Unused import _winreg

ubuntuone_installer/gui/qt/utils/windows.py:
    74: [C0301] Line too long (112/79)
    78: [E0602, add_syncdaemon_to_autostart] Undefined variable 'WindowsError'

review: Needs Fixing

« Back to merge proposal