Merge lp:~ralsina/ubuntuone-windows-installer/put-in-autostart into lp:ubuntuone-windows-installer
Proposed by
Roberto Alsina
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Roberto Alsina | ||||||||
Approved revision: | 66 | ||||||||
Merged at revision: | 59 | ||||||||
Proposed branch: | lp:~ralsina/ubuntuone-windows-installer/put-in-autostart | ||||||||
Merge into: | lp:ubuntuone-windows-installer | ||||||||
Diff against target: |
393 lines (+200/-20) 9 files modified
data/qt/congratulations.ui (+44/-9) ubuntuone_installer/gui/qt/gui.py (+3/-0) ubuntuone_installer/gui/qt/setup_account.py (+11/-7) ubuntuone_installer/gui/qt/tests/test_gui.py (+12/-1) ubuntuone_installer/gui/qt/tests/test_setup_account.py (+10/-1) ubuntuone_installer/gui/qt/utils/__init__.py (+2/-0) ubuntuone_installer/gui/qt/utils/linux.py (+8/-0) ubuntuone_installer/gui/qt/utils/tests/test_windows.py (+83/-0) ubuntuone_installer/gui/qt/utils/windows.py (+27/-2) |
||||||||
To merge this branch: | bzr merge lp:~ralsina/ubuntuone-windows-installer/put-in-autostart | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Natalia Bidart (community) | Approve | ||
Review via email:
|
Commit message
* Adds a missing image to the final page of the wizard
* Adds syncdaemon to autostart
Description of the change
* Adds a missing image to the final page of the wizard
* Adds syncdaemon to autostart
To post a comment you must log in.
ubuntuone_ installer/ gui/qt/ utils/tests/ test_windows. py: ConnectRegistry ] Invalid name "ConnectRegistry" (should match ([a-z_] [a-z0-9_ ]{2,79} $|setUp| tearDown) ) ConnectRegistry ] Missing docstring OpenKey] Invalid name "OpenKey" (should match ([a-z_] [a-z0-9_ ]{2,79} $|setUp| tearDown) ) OpenKey] Missing docstring CloseKey] Invalid name "CloseKey" (should match ([a-z_] [a-z0-9_ ]{2,79} $|setUp| tearDown) ) CloseKey] Missing docstring QueryValueEx] Invalid name "QueryValueEx" (should match ([a-z_] [a-z0-9_ ]{2,79} $|setUp| tearDown) ) QueryValueEx] Missing docstring QueryValueEx] Attribute 'query_args' defined outside __init__ OpenKey] Attribute 'openkey_args' defined outside __init__ CloseKey] Attribute 'closekey_args' defined outside __init__ ConnectRegistry ] Attribute 'connect_args' defined outside __init__
96: [C0301] Line too long (89/79)
97: [C0301] Line too long (148/79)
73: [C0103, FakeRegistry.
73: [C0111, FakeRegistry.
77: [C0103, FakeRegistry.
77: [C0111, FakeRegistry.
81: [C0103, FakeRegistry.
81: [C0111, FakeRegistry.
84: [C0103, FakeRegistry.
84: [C0111, FakeRegistry.
85: [W0201, FakeRegistry.
78: [W0201, FakeRegistry.
82: [W0201, FakeRegistry.
74: [W0201, FakeRegistry.
27: [W0611] Unused import _winreg
ubuntuone_ installer/ gui/qt/ utils/windows. py: to_autostart] Undefined variable 'WindowsError'
74: [C0301] Line too long (112/79)
78: [E0602, add_syncdaemon_