> Please rename the function for this to something more than one character
> different from the _is_shared method. Documenting API is good, but so is
> having sane method names. :)
Done.
> Also, please use --fixes=lp:712674 on at least one commit, so that the bug is
> linked and gets marked as fix committed when the branch lands.
>
> Also, set a more descriptive commit message than "Fix bug ####" please. We
> don't need to put bug #s in commit messages, as bzr/launchpad have useful
> metadata for them that we should use.
I am used to a system where the link is done by just mentioning the bugs in the commit messages, sorry.
> Please rename the function for this to something more than one character
> different from the _is_shared method. Documenting API is good, but so is
> having sane method names. :)
Done.
> Also, please use --fixes=lp:712674 on at least one commit, so that the bug is
> linked and gets marked as fix committed when the branch lands.
>
> Also, set a more descriptive commit message than "Fix bug ####" please. We
> don't need to put bug #s in commit messages, as bzr/launchpad have useful
> metadata for them that we should use.
I am used to a system where the link is done by just mentioning the bugs in the commit messages, sorry.
Fixed!