Code review comment for lp:~raharper/curtin/trunk.fix-tox-errors

Revision history for this message
Ryan Harper (raharper) wrote :

I'll likely take both your changes here once I can get vmtest to sync
images properly to my system for testing.

On Wed, Mar 30, 2016 at 6:55 PM, Scott Moser <email address hidden> wrote:

> i'm ok with the change you suggest though.
> The one thing is that when this code was put in, the intent was probably
> to allow args to be passed into main directly without the user having to
> modify sys.argv, but the code was lacking in doing that.
>
> I suspect a patch like this would be more along the lines of what i
> intended, it also passes pylint.
>
> http://paste.ubuntu.com/15564028/
> --
>
> https://code.launchpad.net/~raharper/curtin/trunk.fix-tox-errors/+merge/290531
> You are the owner of lp:~raharper/curtin/trunk.fix-tox-errors.
>

« Back to merge proposal