lp:~raharper/curtin/trunk.fix-tox-errors

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 366

Server Team CI bot: Approve (continuous-integration) on 2016-03-31

Scott Moser: Pending requested 2016-03-30

Diff: 56 lines (+7/-7)

2 files modified

curtin/commands/main.py (+5/-5)
tox.ini (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

367. By Ryan Harper on 2016-03-31

Further fixes: specify pylint version and restore use-case of handling args

366. By Ryan Harper on 2016-03-30

curtin: fix tox errors in commands/main.py

Unexpectedly, pylint now blows up with the following errors:

E:208,13: Instance of 'argv' has no 'reportstack' member (but some types could
        not be inferred) (maybe-no-member)
E:209,18: Instance of 'argv' has no 'func' member (but some types could not be
        inferred) (maybe-no-member)

This code has been in tree for a very long time, this only shows up when
we added pylint to the tox run (revno 335). This should have always failed.

With that said, the fix is simple. In main(), we define args to be sys.argv
but it's not used until later we re-assign args to be something else from
argparser. Removing that useless initialization as a argv type resolves
the lint error.

365. By Scott Moser on 2016-03-18

debian/control: fix build-depends for xenial build

python3 support was moved out of pyflakes into python3-pyflakes.
Adjust the package to build on trusty where python3-pyflakes was
not present and also on xenial where it is.

Note, this does mean that sbuild now requires '--resolve-alternatives'.
That is how it is used on launchpad but is not the default in sbuild.

364. By Scott Moser on 2016-03-18

fix pep8 issue on trusty, add a tox environment to catch that.

Recent merge worked fine in tox, but build on trusty failed due
to pep8 complaints. This adds a 'trusty-check' environment
to tox that will catch errors like that.

363. By Scott Moser on 2016-03-18

mkfs: handle fstype: vfat

Prior to commit 343, block_meta custom handled 'fstype: vfat' via
fallthrough and invoked mkfs.vfat without options. Restore this by adding
'vfat' to the fstype dictionary. Add a unittest to ensure we don't break
fstype: vfat in the future.

362. By Scott Moser on 2016-03-11

save the curtin install config to /root/curtin-install-cfg.yaml

this is configurable via 'save_install_config'.
Setting the value to non-true value ("" or null) will stop
the writing of this file.

361. By Scott Moser on 2016-03-09

deps: install dependencies without apt recommends

Curtin should list the dependencies it has explicitly rather than
relying on recommends. That has 2 benefits:
a.) better knowing what the dependencies actually are
b.) smaller footprint/less installed packages.

Specifically, this means that on the following releases, we do
not install the listed packages:
 precise: default-mta mail-transport-agent
 trusty: default-mta mail-transport-agent
 vivid: default-mta mail-transport-agent
 wily: default-mta mail-transport-agent module-init-tools

There are no changes to packages installed as deps in xenial, as
xenial maas/cloud image already has all dependencies.

Note, this only affects how curtin installs its *own* dependencies
(through 'curtin --install-deps') not how apt would install it.

360. By Scott Moser on 2016-03-04

fix tox running for python2 on trusty

This is similar to commit 350. We do not run python2 checkers
against tests/vmtests.

For some reason this just started failing. The change is to just
add a py2-flake8 and py3-flake8 environment. Note, we are not running
py2-flake8 by default right now (its not in the env list)

359. By Scott Moser on 2016-02-25

tools/ssh-keys-list: fix a bug in modes, add argparse

There was actually no way to request 'json' output. And the mode
'public-keys' would result in a stack trace.

This fixes those 2 issues and adds argparse so we get some help.

358. By Ryan Harper on 2016-02-24

Add bond parsing & improved source, source-directory parsing for /e/n/i.

This give the ability for the parser to handle bond interface in the
/etc/network/interfaces configuration. The resulting dictionary will contain a
bond dictionary if any bond options are defined for that interface definition
in /etc/network/interfaces.
Improves the source and source-directory parsing to match was is documented in
/etc/network/interfaces for ubuntu.
Supports parsing glob in both source and source-directory and performs regex
matching for source-directory to parse the same as /etc/network/interfaces is
defined. A _source_path key is provided in each dictionary entry for each
element defining the path the interface was created.