Code review comment for lp:~raharper/curtin/trunk.fix-raid-over-iscsi

Revision history for this message
Scott Moser (smoser) wrote :

this is fine.
my only comment is that 'sdpath' is wierd as an argument and i'd never expect anythign to use it.

i realize it is just for testing. Woudl it be better to just use 'os.path.isdir()' rather than the lstat? and then you could easily mock the response to that.

« Back to merge proposal