lp:~raharper/curtin/trunk.fix-raid-over-iscsi

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 526

Server Team CI bot: Approve (continuous-integration) on 2017-09-12

Scott Moser (community): Approve on 2017-09-12

Diff: 154 lines (+95/-5)

5 files modified

curtin/block/iscsi.py (+9/-0)
curtin/commands/install.py (+17/-5)
curtin/util.py (+14/-0)
tests/unittests/test_util.py (+51/-0)
tests/vmtests/test_mdadm_iscsi.py (+4/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

530. By Ryan Harper on 2017-09-12

Drop useless tmp_dir() in uses_systemd unittest

529. By Ryan Harper on 2017-09-12

Replace os.lstat with os.path.isdir; drop sdpath arg; adjust unittests

528. By Ryan Harper on 2017-09-08

Add additional documentation in install.py on why we restart iscsi service

527. By Ryan Harper on 2017-09-08

uses_systemd: add caching, drop target_path use, ephemeral only

526. By Ryan Harper on 2017-09-08

merge from trunk

525. By Ryan Harper on 2017-09-06

Instead of forcing a disconnect; ensure iscsi service is running which handles disconnect already

524. By Joshua Powers on 2017-09-01

vmtest: catch exceptions in curtin-log-print

Wraps the calling of curtin-log-print to catch any exceptions
that result. Was causing large image files to be left behind as
an exception generated by the curtin-log-print prevented proper
cleanup.

LP: #1714592

523. By Ryan Harper on 2017-09-01

iscsi: use curtin storage config to disconnect iscsi targets

When curtin disconnects from iscsi targets after an install, it does so
after unmounting the targets, however it passed the target dir into the
iscsi disconnect code which then silently failed to find any
session configurations.

We've been lucky as the existing shutdown iscsi service has been
logging out of sessions defined on the host; however on recent
Artful systems, the open-iscsi service is not restarted after
populating /etc/iscsi/nodes directory and since it is not running
in the ephemeral environment the service will not automatically
stop the iscsi devices, causing a hang on shutdown.

To resolve this parse the curtin storage config for iscsi disks,
construct IscsiDisk objects and then call their disconnect() method.
In addition to this logic fix, this branch contains:

- adds a missing Artful LVM Iscsi vmtest class
- Updated logging messages in iscsi paths, including
  a message when iscsi_disconnect doesn't find the
  /etc/iscsi/nodes directory.
- Updated IscsiDisk disconnect with similar logging

522. By Ryan Harper on 2017-08-22

vmtests: bump skip_by_date values out to give cloud-init SRU more time

521. By Scott Moser on 2017-08-15

vmtest: get info about collected symlinks and then delete them.

Some of the 'collect' scripts collect files with 'cp -a' or other
means that would collect a symbolic link. Since none of our
scripts yet handle properly resolving absolute symlinks we just
remove all symlinks and write a file 'symlinks.txt' with info about them.

At a later date we might need to also clean out sockets or other content.

The primary motivation for this is to
a.) make sure tests don't inadvertantly read the target of the symlink
    and thus "verify" files on the host
b.) jenkins can produce a zip file of the artifacts, and we suspect that
    it is bothered by the symbolic links.