Merge ~raharper/curtin:fix/py27-setuptools-less-that-45 into curtin:master

Proposed by Ryan Harper
Status: Merged
Approved by: Ryan Harper
Approved revision: 9bfb20e5a02d761c9904546a98401c18297e9724
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~raharper/curtin:fix/py27-setuptools-less-that-45
Merge into: curtin:master
Diff against target: 13 lines (+2/-0)
1 file modified
tox.ini (+2/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Chad Smith Approve
Review via email: mp+380183@code.launchpad.net

Commit message

tox: pin setuptools < 45 to allow installing py27 in virtenv

setuptools release 45 broke everyone who installed py27[1]. Fix
this by using the previous release.

1. https://github.com/pypa/setuptools/issues/1963

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) :
review: Needs Fixing
9bfb20e... by Ryan Harper

Add github issue related to the change

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Chad Smith (chad.smith) wrote :

WFM

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/tox.ini b/tox.ini
index 3a8e40e..dad09cc 100644
--- a/tox.ini
+++ b/tox.ini
@@ -29,6 +29,8 @@ basepython = python3
2929
30[testenv:py27]30[testenv:py27]
31basepython = python2.731basepython = python2.7
32# https://github.com/pypa/setuptools/issues/1963
33deps = setuptools<45
3234
33# tox uses '--pre' by default to pip install. We don't want that, and35# tox uses '--pre' by default to pip install. We don't want that, and
34# 'pip_pre=False' isn't available until tox version 1.9.36# 'pip_pre=False' isn't available until tox version 1.9.

Subscribers

People subscribed via source and target branches