Code review comment for ~rafaeldtinoco/+git/net-snmp:lp1855943-focal

> Do we know in which version debian/patches/mysql8-replace-bool.patch will
> appear?
> If so could we add "Applied-Upstream: <version>" so that we know when we can
> drop it?

It would stay like this:

  Description: replace my_bool with char since the former was dropped in mysql8
  Origin: https://sourceforge.net/p/net-snmp/code/ci/9f4af8c42d515e6b214738cc97212dfbe7f749cf/
  Bug: https://sourceforge.net/p/net-snmp/bugs/2922/
  Bug-Ubuntu: https://bugs.launchpad.net/bugs/1814270
+ Applied-Upstream: https://github.com/net-snmp/net-snmp/commit/9f4af8c42d51
  Last-Update: 2019-02-06
  ---
  This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
  --- a/apps/snmptrapd_sql.c
  +++ b/apps/snmptrapd_sql.c
  @@ -194,7 +194,7 @@ typedef struct sql_buf_t {
    * static bind structures, plus 2 static buffers to bind to.
    */
   static MYSQL_BIND _tbind[TBIND_MAX], _vbind[VBIND_MAX];
  -static my_bool _no_v3;
  +static char _no_v3;

   static void _sql_process_queue(u_int dontcare, void *meeither);

But the "Origin" already uses the same commit id, so I think it is not needed, right ?

Let me know if you prefer it to be added anyway.

I can add a:

[Upstream v5.8.rc4-180-g9f4af8c42] tag bellow changelog maybe ?

Not sure if needed also.

Tks!