Merge ~rafaeldtinoco/+git/net-snmp:lp1855943-focal into ~rafaeldtinoco/+git/net-snmp:debian/sid

Proposed by Rafael David Tinoco
Status: Rejected
Rejected by: Rafael David Tinoco
Proposed branch: ~rafaeldtinoco/+git/net-snmp:lp1855943-focal
Merge into: ~rafaeldtinoco/+git/net-snmp:debian/sid
Diff against target: 1460 lines (+1221/-4)
10 files modified
debian/changelog (+827/-0)
debian/control (+4/-3)
debian/patches/HOST-MIB-Fix-a-recently-introduced-bug.patch (+28/-0)
debian/patches/HOST-MIB-Skip-autofs-entries.patch (+230/-0)
debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch (+32/-0)
debian/patches/fix-check-hr-filesys-autofs.patch (+36/-0)
debian/patches/mysql8-replace-bool.patch (+18/-0)
debian/patches/series (+5/-0)
debian/rules (+5/-1)
debian/source.apport (+36/-0)
Reviewer Review Type Date Requested Status
Rafael David Tinoco Disapprove
Review via email: mp+376741@code.launchpad.net

Commit message

I'm using lp:~rafaeldtinoco/+git/net-snmp instead of lp:ubuntu/+source/net-snmp because currently launchpad git backend has issues when trying to clone (internally) repos with big number of refs (they're working on it).

Since rafaeldtinoco/+git/net-snmp is a full clone (it works) this review will likely work okay (just like git-ubuntu).

BUG: https://bugs.launchpad.net/ubuntu/+source/
PPA: https://launchpad.net/~rafaeldtinoco/+archive/ubuntu/lp1855943

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The drop+add for 1835818 seemed odd at first but eventually right to me

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Do we know in which version debian/patches/mysql8-replace-bool.patch will appear?
If so could we add "Applied-Upstream: <version>" so that we know when we can drop it?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Same question for debian/patches/fix-check-hr-filesys-autofs.patch

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Is is sad that https://sourceforge.net/p/net-snmp/bugs/2792/ doesn't move forward, but ok nothing to do for us - ok as it is

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

On the added patches you wrote:
  [Upstream patches since v5.8.rc4]
But this is V5.8 so they should already be included we we don't need the patches anymore right?
I'm confused could you explain the details behind this?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog otherwise looks good.

I didn't have time for the full review and tests today.
But I hope this gives you enough to clarify so that the following real-review by me or others will immediately lead to a +1 then.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

> The drop+add for 1835818 seemed odd at first but eventually right to me

Yep, it was better as the other didn't apply cleanly and wasn't backed by upstream one.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

> Do we know in which version debian/patches/mysql8-replace-bool.patch will
> appear?
> If so could we add "Applied-Upstream: <version>" so that we know when we can
> drop it?

It would stay like this:

  Description: replace my_bool with char since the former was dropped in mysql8
  Origin: https://sourceforge.net/p/net-snmp/code/ci/9f4af8c42d515e6b214738cc97212dfbe7f749cf/
  Bug: https://sourceforge.net/p/net-snmp/bugs/2922/
  Bug-Ubuntu: https://bugs.launchpad.net/bugs/1814270
+ Applied-Upstream: https://github.com/net-snmp/net-snmp/commit/9f4af8c42d51
  Last-Update: 2019-02-06
  ---
  This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
  --- a/apps/snmptrapd_sql.c
  +++ b/apps/snmptrapd_sql.c
  @@ -194,7 +194,7 @@ typedef struct sql_buf_t {
    * static bind structures, plus 2 static buffers to bind to.
    */
   static MYSQL_BIND _tbind[TBIND_MAX], _vbind[VBIND_MAX];
  -static my_bool _no_v3;
  +static char _no_v3;

   static void _sql_process_queue(u_int dontcare, void *meeither);

But the "Origin" already uses the same commit id, so I think it is not needed, right ?

Let me know if you prefer it to be added anyway.

I can add a:

[Upstream v5.8.rc4-180-g9f4af8c42] tag bellow changelog maybe ?

Not sure if needed also.

Tks!

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

> Same question for debian/patches/fix-check-hr-filesys-autofs.patch

This commit also has a DEP3 pointing to upstream patch.

Should I do something else ?

----
Description: HOST-MIB, hr_filesys: Fix Check_HR_FileSys_AutoFs()

 On Linux getmntent() is available but getfsstat() not. Hence remove #if
 HAVE_GETFSSTAT from around the HRFS_type check.

 See also https://sourceforge.net/p/net-snmp/patches/1350/.
 Fixes: cf41e6e91015 ("HOST-MIB: Skip autofs entries").
Author: Bart Van Assche <email address hidden>
Origin: upstream, https://github.com/net-snmp/net-snmp/commit/bcb1a6b8afc444bbcd099a195e08f0b01cbc8f6b
Bug: https://sourceforge.net/p/net-snmp/patches/1350/
Bug-Ubuntu: https://launchpad.net/bugs/1843036
----

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

I'm doing a new merge request in the correct place now and will link it here for a +1.

Thanks for reviewing this Christian!

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Christian,

I have addressed your comments in here:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/net-snmp/+git/net-snmp/+merge/376795
So I'm disapproving this one.
Would you mind continuing from there ?

Thank you!

review: Disapprove
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

On Fri, Dec 13, 2019 at 5:30 PM Rafael David Tinoco <
<email address hidden>> wrote:

> > Do we know in which version debian/patches/mysql8-replace-bool.patch will
> > appear?
> > If so could we add "Applied-Upstream: <version>" so that we know when we
> can
> > drop it?
>
> It would stay like this:
>
> Description: replace my_bool with char since the former was dropped in
> mysql8
> Origin:
> https://sourceforge.net/p/net-snmp/code/ci/9f4af8c42d515e6b214738cc97212dfbe7f749cf/
> Bug: https://sourceforge.net/p/net-snmp/bugs/2922/
> Bug-Ubuntu: https://bugs.launchpad.net/bugs/1814270
> + Applied-Upstream:
> https://github.com/net-snmp/net-snmp/commit/9f4af8c42d51
> Last-Update: 2019-02-06
> ---
> This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
> --- a/apps/snmptrapd_sql.c
> +++ b/apps/snmptrapd_sql.c
> @@ -194,7 +194,7 @@ typedef struct sql_buf_t {
> * static bind structures, plus 2 static buffers to bind to.
> */
> static MYSQL_BIND _tbind[TBIND_MAX], _vbind[VBIND_MAX];
> -static my_bool _no_v3;
> +static char _no_v3;
>
> static void _sql_process_queue(u_int dontcare, void *meeither);
>
> But the "Origin" already uses the same commit id, so I think it is not
> needed, right ?
>

From Dep3: It may contain the upstream version expected to contain this
patch, or the URL or commit identifier of the upstream commit
In this case what would help is just the version (not the commit) like:
Applied-Upstream: v5.8.rc5 <- or whatever version is true

I even once had something like (in case this applies here):
Applied-Upstream: in git (see origin), but not in any upstream release yet

That way one knows when it is expected to be droppable without checking the
upstream git first.

Let me know if you prefer it to be added anyway.
>
> I can add a:
>
> [Upstream v5.8.rc4-180-g9f4af8c42] tag bellow changelog maybe ?
>
> Not sure if needed also.
>

Ack - I don't think that it would help to put this in the changelog.

> Tks!
> --
> https://code.launchpad.net/~rafaeldtinoco/+git/net-snmp/+merge/376741
> Your team Canonical Server Team is requested to review the proposed merge
> of ~rafaeldtinoco/+git/net-snmp:lp1855943-focal into
> ~rafaeldtinoco/+git/net-snmp:debian/sid.
>

--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Arr, inbox ordering - yeah continuing on the other one ...
Marking this one rejected

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

If only I could ... could you do so at the top?

Unmerged commits

bfea455... by Rafael David Tinoco

update-maintainer

6a6571b... by Rafael David Tinoco

reconstruct-changelog

98e403f... by Rafael David Tinoco

merge-changelogs

e02bbf6... by Rafael David Tinoco

 * d/p/fix-check-hr-filesys-autofs.patch:
   - On Linux getmntent() is available but getfsstat() not.
     Hence remove #if HAVE_GETFSSTAT from around the HRFS_type
     check.

73c5593... by Rafael David Tinoco

 * Drop:
   - d/p/put-paranthesis-around-macros-which-are-expressions.patch:
     put paranthesis around macros which are expressions. (LP: #1843036)
     [Fixed in 5.8+dfsg-2]

9f43202... by Rafael David Tinoco

 * Skip autofs entries when calling statfs to prevent autofs
   being mounted on snmpd startup (LP: #1835818):
   - d/p/HOST-MIB-Fix-a-recently-introduced-bug.patch
   - d/p/HOST-MIB-Skip-autofs-entries.patch
     [Upstream patches since v5.8.rc4]

6d1063b... by Rafael David Tinoco

 * Drop:
   - Skip autofs entries when calling statfs to prevent autofs
     being mounted on snmpd startup (LP: #1835818):
     - d/p/autofs-skip-autofs-entries.patch
     - d/p/autofs-fix-a-recently-introduced-bug.patch
       [Non-upstream patches]

ef2e5f4... by Rafael David Tinoco

 * Drop:
   - d/p/mysql-options.patch: use mysql_options if no
     {my_,}load_defaults was found. (LP: #1814270)
     [Fixed in 5.8+dfsg-2]

96f542f... by Rafael David Tinoco

 * Drop:
   - d/p/mysql-init.patch: handle the various mysql init
     functions. (LP: #1814270)
     [Fixed in 5.8+dfsg-2]

5bd62cc... by Rafael David Tinoco

 * Drop:
   - d/p/mysql8-headers.patch: detect if my_global.h and my_sys.h are
     available. (LP: #1814270)
     [Fixed in 5.8+dfsg-2]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8482bb7..613f720 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,42 @@
6+net-snmp (5.8+dfsg-2ubuntu1) focal; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #1855943). Remaining changes:
9+ - d/p/fix-check-hr-filesys-autofs.patch (LP #1843036)
10+ - d/p/mysql8-replace-bool.patch: fix build with mysql-8 (LP 1814270)
11+ - d/p/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch: Link
12+ libnetsnmptrapd against MYSQL_LIBS.
13+ - Add apport hook.
14+ - d/control: add dh-apport to Build-Depends
15+ - d/rules: install the apport hook via debhelper
16+ - d/source.apport: apport hook
17+ * Dropped patches that are upstream and in Debian 5.8+dfsg-2:
18+ - d/p/put-paranthesis-around-macros-which-are-expressions.patch
19+ (LP #1843036)
20+ - Fix build with mysql-8 (LP #1814270):
21+ - d/p/mysql-options.patch: use mysql_options if no {my_,}load_defaults
22+ was found.
23+ - d/p/mysql-init.patch: handle the various mysql init functions.
24+ - d/p/mysql8-headers.patch: detect if my_global.h and my_sys.h are
25+ available.
26+ - d/p/my-load-defaults.patch: properly detect (and use)
27+ my_load_defaults().
28+ - d/p/snmptrapd_mysql_init: no need to drop this patch anymore
29+ (LP #1814254)
30+ - d/p/0001-swinst_apt.c-Fix-indexing-of-hrSWInstalledTable-to-s.patch
31+ (LP #1314760)
32+ * Dropped patches:
33+ - Skip autofs entries when calling statfs (LP #1835818):
34+ - d/p/autofs-skip-autofs-entries.patch
35+ - d/p/autofs-fix-a-recently-introduced-bug.patch
36+ [Non-upstream patches, merge conflicts]
37+ * Added changes:
38+ - Skip autofs entries when calling statfs (LP #1835818):
39+ + d/p/HOST-MIB-Fix-a-recently-introduced-bug.patch
40+ + d/p/HOST-MIB-Skip-autofs-entries.patch
41+ [Upstream patches since v5.8.rc4, clean cherry-picks]
42+
43+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Fri, 13 Dec 2019 03:27:52 +0000
44+
45 net-snmp (5.8+dfsg-2) unstable; urgency=medium
46
47 * All MIB directory values removed and just use the default compile-time
48@@ -30,6 +69,87 @@ net-snmp (5.8+dfsg-1) unstable; urgency=medium
49
50 -- Craig Small <csmall@debian.org> Thu, 10 Oct 2019 22:37:15 +1100
51
52+net-snmp (5.7.3+dfsg-5ubuntu6) focal; urgency=medium
53+
54+ * No-change rebuild for the perl update.
55+
56+ -- Matthias Klose <doko@ubuntu.com> Fri, 18 Oct 2019 19:37:07 +0000
57+
58+net-snmp (5.7.3+dfsg-5ubuntu5) eoan; urgency=medium
59+
60+ * d/p/fix-check-hr-filesys-autofs.patch:
61+ - On Linux getmntent() is available but getfsstat() not.
62+ Hence remove #if HAVE_GETFSSTAT from around the HRFS_type
63+ check.
64+
65+ -- Eric Desrochers <eric.desrochers@canonical.com> Sat, 07 Sep 2019 16:30:53 +0000
66+
67+net-snmp (5.7.3+dfsg-5ubuntu4) eoan; urgency=medium
68+
69+ * d/p/put-paranthesis-around-macros-which-are-expressions.patch:
70+ - put paranthesis around macros which are expressions.
71+ (LP: #1843036)
72+
73+ -- Eric Desrochers <eric.desrochers@canonical.com> Fri, 06 Sep 2019 23:15:43 +0000
74+
75+net-snmp (5.7.3+dfsg-5ubuntu3) eoan; urgency=medium
76+
77+ * Skip autofs entries when calling statfs to prevent autofs being mounted on
78+ snmpd startup (LP: #1835818):
79+ - d/p/autofs-skip-autofs-entries.patch
80+ - d/p/autofs-fix-a-recently-introduced-bug.patch
81+
82+ -- Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com> Wed, 21 Aug 2019 12:22:37 +0100
83+
84+net-snmp (5.7.3+dfsg-5ubuntu2) eoan; urgency=medium
85+
86+ * No change rebuild for libmysqlclient21.
87+
88+ -- Robie Basak <robie.basak@ubuntu.com> Mon, 12 Aug 2019 11:32:18 +0000
89+
90+net-snmp (5.7.3+dfsg-5ubuntu1) disco; urgency=medium
91+
92+ * Merge with Debian unstable. Remaining changes:
93+ - Add apport hook.
94+ + d/control: add dh-apport to Build-Depends
95+ + d/rules: install the apport hook via debhelper
96+ + d/source.apport: apport hook
97+ - d/p/0001-swinst_apt.c-Fix-indexing-of-hrSWInstalledTable-to-s.patch:
98+ set first hrSWInstalledIndex to 1 to follow RFC 2790 (LP #1314760)
99+ * Drop:
100+ - SECURITY UPDATE: DoS via NULL pointer exception
101+ + debian/patches/CVE-2018-18065.patch: fix logic in
102+ agent/helpers/table.c.
103+ + CVE-2018-18065
104+ [Fixed in 5.7.3+dfsg-4]
105+ - d/p/my_load_defaults: use my_load_defaults instead of the
106+ libmysqlclient-internal load_defaults (LP #1565003). Thanks to Lars
107+ Tangvald.
108+ [Replaced by a more complete patch]
109+ - debian/rules: Fix calculation of UPSTREAM_VERSION and COMPAT_VERSION.
110+ [No more needed since 5.7.3+dfsg-5]
111+ * Added:
112+ - d/p/snmptrapd_mysql_init: drop this patch. The first part fixes builds
113+ with newer mariadb, which Ubuntu doesn't use, and the second part is
114+ an unrelated change which we are fixing in another patch (see #1814254
115+ for details).
116+ - d/p/0001-Link-libnetsnmptrapd-against-MYSQL_LIBS.patch: Link
117+ libnetsnmptrapd against MYSQL_LIBS. Thanks to Adam
118+ Williamson <awilliam@redhat.com>. (Closes: #886221, LP: #1814254)
119+ - Fix build with mysql-8 (LP: #1814270):
120+ + d/p/mysql8-replace-bool.patch: newer mysql dropped my_bool, use char
121+ instead.
122+ + d/p/my-load-defaults.patch: properly detect (and use)
123+ my_load_defaults(). This replaces the previous
124+ my_load_defaults patch.
125+ + d/p/mysql8-headers.patch: detect if my_global.h and my_sys.h are
126+ available
127+ + d/p/mysql-init.patch: handle the various mysql init functions
128+ + d/p/mysql-options.patch: use mysql_options if no {my_,}load_defaults
129+ was found.
130+
131+ -- Andreas Hasenack <andreas@canonical.com> Tue, 05 Feb 2019 16:00:35 -0200
132+
133 net-snmp (5.7.3+dfsg-5) unstable; urgency=medium
134
135 * Use debhelper macros for shlibs Closes: #912685
136@@ -93,6 +213,60 @@ net-snmp (5.7.3+dfsg-2) unstable; urgency=medium
137
138 -- Craig Small <csmall@debian.org> Sat, 31 Mar 2018 20:00:51 +1100
139
140+net-snmp (5.7.3+dfsg-1.8ubuntu5) disco; urgency=medium
141+
142+ * No-change rebuild against latest lm-sensors
143+
144+ -- Jeremy Bicha <jbicha@ubuntu.com> Wed, 02 Jan 2019 17:37:45 -0500
145+
146+net-snmp (5.7.3+dfsg-1.8ubuntu4) disco; urgency=medium
147+
148+ * debian/rules: Fix calculation of UPSTREAM_VERSION and COMPAT_VERSION.
149+
150+ -- Adam Conrad <adconrad@ubuntu.com> Mon, 05 Nov 2018 13:22:39 -0700
151+
152+net-snmp (5.7.3+dfsg-1.8ubuntu3.18.10.1) cosmic-security; urgency=medium
153+
154+ * SECURITY UPDATE: DoS via NULL pointer exception
155+ - debian/patches/CVE-2018-18065.patch: fix logic in
156+ agent/helpers/table.c.
157+ - CVE-2018-18065
158+
159+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 22 Oct 2018 08:03:49 -0400
160+
161+net-snmp (5.7.3+dfsg-1.8ubuntu3) bionic; urgency=medium
162+
163+ * d/p/0001-swinst_apt.c-Fix-indexing-of-hrSWInstalledTable-to-s.patch:
164+ set first hrSWInstalledIndex to 1 to follow RFC 2790 (LP: #1314760)
165+
166+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 20 Feb 2018 15:24:41 +0100
167+
168+net-snmp (5.7.3+dfsg-1.8ubuntu2) bionic; urgency=high
169+
170+ * No change rebuild against openssl1.1.
171+
172+ -- Dimitri John Ledkov <xnox@ubuntu.com> Tue, 06 Feb 2018 17:54:39 +0000
173+
174+net-snmp (5.7.3+dfsg-1.8ubuntu1) bionic; urgency=medium
175+
176+ * Merge with Debian unstable (LP: #1742518). Remaining changes:
177+ - Add apport hook.
178+ + d/control: add dh-apport to Build-Depends
179+ + d/rules: install the apport hook via debhelper
180+ + d/source.apport: apport hook
181+ - d/p/my_load_defaults: use my_load_defaults instead of the
182+ libmysqlclient-internal load_defaults (LP #1565003). Thanks to Lars
183+ Tangvald.
184+ * Dropped:
185+ - Avoid installing links in rc[06].d.
186+ [It's not clear what it was trying to solve (no details or bug
187+ number), but update-rc.d no longer takes start/stop arguments and
188+ this delta was actually resulting in warnings during the installation.
189+ Also, Ubuntu is using systemd now and this package has systemd service
190+ files.]
191+
192+ -- Andreas Hasenack <andreas@canonical.com> Thu, 11 Jan 2018 16:07:07 -0200
193+
194 net-snmp (5.7.3+dfsg-1.8) unstable; urgency=medium
195
196 * Non-maintainer upload.
197@@ -104,6 +278,43 @@ net-snmp (5.7.3+dfsg-1.8) unstable; urgency=medium
198
199 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sat, 23 Dec 2017 23:48:23 +0100
200
201+net-snmp (5.7.3+dfsg-1.7ubuntu1) artful; urgency=medium
202+
203+ * Merge with Debian unstable (LP: #1712569). Remaining changes:
204+ - Add apport hook.
205+ + d/control: add dh-apport to Build-Depends
206+ + d/rules: install the apport hook via debhelper
207+ + d/source.apport: apport hook
208+ - Avoid installing links in rc[06].d.
209+ - d/p/my_load_defaults: use my_load_defaults instead of the
210+ libmysqlclient-internal load_defaults (LP #1565003). Thanks to Lars
211+ Tangvald.
212+ * Drop:
213+ - SECURITY UPDATE: denial of service and possible code execution via
214+ incompletely parsed varBind variables
215+ + debian/patches/CVE-2015-5621.patch: don't return incorrectly parsed
216+ varbinds in snmplib/snmp_api.c.
217+ + CVE-2015-5621
218+ [Added by Debian as 0025-Bug-788964-net-snmp-snmp_pdu_parse-DoS.patch
219+ in 5.7.3+dfsg-1.1]
220+ - debian/snmp.preinst:
221+ It turns out that the original motivation why killall was added is gone.
222+ So we can just remove the killall introduced by Ubuntu LP #573391
223+ (Closes: #781257, LP #1245604)
224+ [Fixed in Debian 5.7.3+dfsg-1.1]
225+ - Fix "FTBFS with Perl 5.24: error: conflicting types for 'U64'":
226+ add patch from upstream git which removes the U64 typedef from the
227+ Net-SNMP header files.
228+ Thanks to Niky Tyni for extracting the patch.
229+ (Closes: #825014)
230+ [Fixed in Debian 5.7.3+dfsg-1.5]
231+ - Additionally add another patch from upstream git which fixes
232+ perl/*/Makefile.PL to fix build failures with Perl 5.24.
233+ Cf. https://sourceforge.net/p/net-snmp/bugs/2712/
234+ [Fixed in Debian 5.7.3+dfsg-1.5]
235+
236+ -- Andreas Hasenack <andreas@canonical.com> Wed, 23 Aug 2017 10:29:35 -0300
237+
238 net-snmp (5.7.3+dfsg-1.7) unstable; urgency=medium
239
240 [ Niels Thykier ]
241@@ -227,6 +438,68 @@ net-snmp (5.7.3+dfsg-1.1) unstable; urgency=medium
242
243 -- Steinar H. Gunderson <sesse@debian.org> Tue, 29 Mar 2016 10:30:24 +0200
244
245+net-snmp (5.7.3+dfsg-1ubuntu6) artful; urgency=medium
246+
247+ * No-change rebuild for perl 5.26.0.
248+
249+ -- Matthias Klose <doko@ubuntu.com> Wed, 26 Jul 2017 20:11:36 +0000
250+
251+net-snmp (5.7.3+dfsg-1ubuntu5) zesty; urgency=medium
252+
253+ * Cherry-pick two patches from Debian's 5.7.3+dfsg-1.5:
254+ * Fix "FTBFS with Perl 5.24: error: conflicting types for 'U64'":
255+ add patch from upstream git which removes the U64 typedef from the
256+ Net-SNMP header files.
257+ Thanks to Niky Tyni for extracting the patch.
258+ (Closes: #825014)
259+ * Additionally add another patch from upstream git which fixes
260+ perl/*/Makefile.PL to fix build failures with Perl 5.24.
261+ Cf. https://sourceforge.net/p/net-snmp/bugs/2712/
262+
263+ -- Iain Lane <iain@orangesquash.org.uk> Tue, 25 Oct 2016 10:28:38 +0100
264+
265+net-snmp (5.7.3+dfsg-1ubuntu4) xenial; urgency=medium
266+
267+ * Rebuild against libmysqlclient20.
268+ * d/p/my_load_defaults: use my_load_defaults instead of the
269+ libmysqlclient-internal load_defaults (LP: #1565003). Thanks to Lars
270+ Tangvald.
271+
272+ -- Robie Basak <robie.basak@ubuntu.com> Tue, 05 Apr 2016 15:17:35 +0000
273+
274+net-snmp (5.7.3+dfsg-1ubuntu3) xenial; urgency=medium
275+
276+ * Rebuild for Perl 5.22.1.
277+
278+ -- Colin Watson <cjwatson@ubuntu.com> Fri, 18 Dec 2015 01:20:38 +0000
279+
280+net-snmp (5.7.3+dfsg-1ubuntu2) wily; urgency=medium
281+
282+ * debian/snmp.preinst:
283+ It turns out that the original motivation why killall was added is gone.
284+ So we can just remove the killall introduced by Ubuntu LP #573391
285+ (Closes: #781257, LP: #1245604)
286+
287+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Fri, 09 Oct 2015 13:18:25 +0200
288+
289+net-snmp (5.7.3+dfsg-1ubuntu1) wily; urgency=medium
290+
291+ * Resynchronise with Debian. Remaining changes:
292+ - Add apport hook.
293+ - Avoid installing links in rc[06].d.
294+ * Dropped patches included in new version:
295+ - debian/patches/00upstream-btrfs.patch
296+ - debian/patches/CVE-2012-6151.patch
297+ - debian/patches/CVE-2014-2284.patch
298+ - debian/patches/CVE-2014-2285.patch
299+ * SECURITY UPDATE: denial of service and possible code execution via
300+ incompletely parsed varBind variables
301+ - debian/patches/CVE-2015-5621.patch: don't return incorrectly parsed
302+ varbinds in snmplib/snmp_api.c.
303+ - CVE-2015-5621
304+
305+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 17 Aug 2015 12:58:43 -0400
306+
307 net-snmp (5.7.3+dfsg-1) unstable; urgency=medium
308
309 * Imported Upstream version 5.7.3+dfsg
310@@ -358,6 +631,56 @@ net-snmp (5.7.2.1~dfsg-1) experimental; urgency=medium
311
312 -- Hideki Yamane <henrich@debian.org> Sun, 30 Mar 2014 19:58:39 +0900
313
314+net-snmp (5.7.2~dfsg-8.1ubuntu5) utopic; urgency=medium
315+
316+ * Backport from 5.7.2.1~dfsg-6.1:
317+ - Fix "hardcodes /usr/lib/perl5":
318+ Make debian/libsnmp-perl.install executable and use
319+ $Config{vendorarch} to get the perl library directory. Patch from Niko
320+ Tyni.
321+ (Closes: #751918)
322+
323+ -- Colin Watson <cjwatson@ubuntu.com> Wed, 20 Aug 2014 11:16:35 +0100
324+
325+net-snmp (5.7.2~dfsg-8.1ubuntu4) utopic; urgency=medium
326+
327+ * Rebuild for Perl 5.20.0.
328+
329+ -- Colin Watson <cjwatson@ubuntu.com> Wed, 20 Aug 2014 00:21:26 +0100
330+
331+net-snmp (5.7.2~dfsg-8.1ubuntu3) trusty; urgency=medium
332+
333+ * SECURITY UPDATE: denial of service via AgentX subagent timeout
334+ - debian/patches/CVE-2012-6151.patch: track cancelled sessions in
335+ agent/mibgroup/agentx/{master.c,master_admin.c}, agent/snmp_agent.c,
336+ include/net-snmp/agent/snmp_agent.h.
337+ - CVE-2012-6151
338+ * SECURITY UPDATE: denial of service when ICMP-MIB is in use
339+ - debian/patches/CVE-2014-2284.patch: fix ICMP mib table handling in
340+ agent/mibgroup/mibII/icmp.c, agent/mibgroup/mibII/kernel_linux.*.
341+ - CVE-2014-2284
342+ * SECURITY UPDATE: denial of service in perl trap handler
343+ - debian/patches/CVE-2014-2285.patch: handle empty community string in
344+ perl/TrapReceiver/TrapReceiver.xs.
345+ - CVE-2014-2285
346+
347+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 08 Apr 2014 08:17:14 -0400
348+
349+net-snmp (5.7.2~dfsg-8.1ubuntu2) trusty; urgency=medium
350+
351+ * Add 00upstream-btrfs.patch: Add btrfs support to hrFSTable. Cherrypicked
352+ from upstream, by way of Nafallo Bjälevik. Thanks! (LP: #1289503)
353+
354+ -- Martin Pitt <martin.pitt@ubuntu.com> Wed, 12 Mar 2014 13:24:18 +0100
355+
356+net-snmp (5.7.2~dfsg-8.1ubuntu1) trusty; urgency=low
357+
358+ * Resynchronise with Debian. Remaining changes:
359+ - Add apport hook.
360+ - Avoid installing links in rc[06].d.
361+
362+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 29 Oct 2013 06:29:46 -0700
363+
364 net-snmp (5.7.2~dfsg-8.1) unstable; urgency=low
365
366 * Non-maintainer upload.
367@@ -367,6 +690,25 @@ net-snmp (5.7.2~dfsg-8.1) unstable; urgency=low
368
369 -- Laurent Bigonville <bigon@debian.org> Sat, 13 Jul 2013 17:13:09 +0200
370
371+net-snmp (5.7.2~dfsg-8ubuntu2) trusty; urgency=low
372+
373+ * Rebuild for Perl 5.18.
374+
375+ -- Colin Watson <cjwatson@ubuntu.com> Mon, 21 Oct 2013 12:30:05 +0100
376+
377+net-snmp (5.7.2~dfsg-8ubuntu1) saucy; urgency=low
378+
379+ * Merge from Debian unstable (LP: #1200516). Remaining changes:
380+ + Add apport hook (LP: #533603):
381+ - debian/source.apport: apport hook
382+ - debian/control: Build-depends on dh-apport.
383+ - debian/rules:
384+ + Add --with apport.
385+ + override_dh_apport to install hook on snmpd package only.
386+ * Call dh_installinit correctly to avoid installing links in rc[06].d
387+
388+ -- Yolanda Robla <yolanda.robla@canonical.com> Fri, 12 Jul 2013 09:47:12 +0200
389+
390 net-snmp (5.7.2~dfsg-8) unstable; urgency=low
391
392 * add libsnmp-perl.preinst to deal with empty directory by libsnmp15
393@@ -415,6 +757,18 @@ net-snmp (5.7.2~dfsg-5) unstable; urgency=low
394
395 -- Hideki Yamane <henrich@debian.org> Sun, 19 May 2013 23:09:52 +0900
396
397+net-snmp (5.7.2~dfsg-4ubuntu1) saucy; urgency=low
398+
399+ * Merge from Debian unstable. Remaining changes:
400+ - debian/rules: Don't stop service in runlevels 0 and 6.
401+ - debian/snmpd.init: LSBify the init script.
402+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
403+ by snmp user before install/uninstall.
404+ - Add apport hook.
405+ * debian/patches/ubuntu-fix-lp-587828.patch: Drop. Fixed upstream.
406+
407+ -- Andres Rodriguez <andreserl@ubuntu.com> Thu, 16 May 2013 21:01:27 -0400
408+
409 net-snmp (5.7.2~dfsg-4) unstable; urgency=low
410
411 * debian/snmpd.{init,default,postinst}
412@@ -595,6 +949,20 @@ net-snmp (5.7.2~dfsg-1~0.1) experimental; urgency=low
413
414 -- Hideki Yamane <henrich@debian.org> Sun, 27 Jan 2013 11:57:29 +0900
415
416+net-snmp (5.4.3~dfsg-2.7ubuntu1) raring; urgency=low
417+
418+ * Merge from Debian unstable. Remaining changes:
419+ - debian/rules: Don't stop service in runlevels 0 and 6.
420+ - debian/snmpd.init: LSBify the init script.
421+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
422+ by snmp user before install/uninstall.
423+ - Add apport hook.
424+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
425+ arches
426+ - debian/{control,rules}: Use dh_python2
427+
428+ -- Logan Rosen <logatronico@gmail.com> Tue, 04 Dec 2012 16:57:00 -0500
429+
430 net-snmp (5.4.3~dfsg-2.7) unstable; urgency=low
431
432 * Non-maintainer upload.
433@@ -611,6 +979,35 @@ net-snmp (5.4.3~dfsg-2.6) unstable; urgency=low
434
435 -- David Prévot <taffit@debian.org> Sun, 18 Nov 2012 09:24:30 -0400
436
437+net-snmp (5.4.3~dfsg-2.5ubuntu1) quantal; urgency=low
438+
439+ * Merge from Debian unstable. Remaining changes:
440+ - debian/rules: Don't stop service in runlevels 0 and 6.
441+ - debian/snmpd.init: LSBify the init script.
442+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
443+ by snmp user before install/uninstall.
444+ - Add apport hook.
445+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
446+ arches
447+ - debian/{control,rules}: Use dh_python2
448+ * Dropped changes:
449+ - debian/patches/50_use_bash.patch: Patch wasn't actually being
450+ applied, and upstream apparently fixed this in 5.4.2.
451+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Patch wasn't actually
452+ being applied, and fix is included in 56_manpage.patch.
453+ - debian/snmpd.postinst: Source debconf before doing work: included in
454+ debian package now.
455+ - debian/patches/99-fix-ubuntu-div0.patch: wasn't applied.
456+ - debian/patches/CVE-2008-6123.*: wasn't applied.
457+ - debian/patches/CVE-2012-2141.patch: use debian's patch.
458+ - debian/README.Debian-source: this change is irrelevant since we
459+ use the debian tarball as-is.
460+ - debian/rules: removed misc irrelevant and undocumented changes.
461+ - debian/snmpd.postinst: no longer need to remove shutdown and reboot
462+ links since this is from Maverick-era.
463+
464+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 20 Jun 2012 09:45:11 -0400
465+
466 net-snmp (5.4.3~dfsg-2.5) unstable; urgency=medium
467
468 * Non-maintainer upload by the Security Team.
469@@ -626,6 +1023,34 @@ net-snmp (5.4.3~dfsg-2.5) unstable; urgency=medium
470
471 -- Luk Claes <luk@debian.org> Sun, 27 May 2012 17:22:01 +0200
472
473+net-snmp (5.4.3~dfsg-2.4ubuntu2) quantal; urgency=low
474+
475+ * SECURITY UPDATE: denial of service via SNMP GET with non-existent
476+ extension table entry
477+ - debian/patches/CVE-2012-2141.patch: validate line_idx in
478+ agent/mibgroup/agent/extend.c.
479+ - CVE-2012-2141
480+
481+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 22 May 2012 16:30:48 -0400
482+
483+net-snmp (5.4.3~dfsg-2.4ubuntu1) precise; urgency=low
484+
485+ * Merge from Debian testing. Remaining changes:
486+ - net-snmp-config: Use bash.
487+ - Removed multiuser option when calling update-rc.d.
488+ - debian/snmpd.init: LSBify the init script.
489+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in
490+ snmpcmd.1.
491+ - debian/snmpd.postinst: Source debconf before doing work.
492+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
493+ by snmp user before install/uninstall.
494+ - Add apport hook.
495+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
496+ arches
497+ - debian/rules: Use dh_python2
498+
499+ -- Chuck Short <zulcss@ubuntu.com> Mon, 23 Jan 2012 09:44:25 -0500
500+
501 net-snmp (5.4.3~dfsg-2.4) unstable; urgency=low
502
503 * Non-maintainer upload.
504@@ -639,6 +1064,35 @@ net-snmp (5.4.3~dfsg-2.4) unstable; urgency=low
505
506 -- Christian Perrier <bubulle@debian.org> Mon, 19 Dec 2011 07:34:31 +0100
507
508+net-snmp (5.4.3~dfsg-2.3ubuntu3) precise; urgency=low
509+
510+ * Build using dh_python2.
511+
512+ -- Matthias Klose <doko@ubuntu.com> Wed, 14 Dec 2011 15:48:05 +0100
513+
514+net-snmp (5.4.3~dfsg-2.3ubuntu2) precise; urgency=low
515+
516+ * Rebuild for Perl 5.14.
517+
518+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 15 Nov 2011 20:49:15 +0000
519+
520+net-snmp (5.4.3~dfsg-2.3ubuntu1) precise; urgency=low
521+
522+ * Merge from debian unstable. Remaining changes:
523+ - net-snmp-config: Use bash.
524+ - Removed multiuser option when calling update-rc.d.
525+ - debian/snmpd.init: LSBify the init script.
526+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in
527+ snmpcmd.1.
528+ - debian/snmpd.postinst: Source debconf before doing work.
529+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
530+ by snmp user before install/uninstall.
531+ - Add apport hook.
532+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
533+ arches.
534+
535+ -- Chuck Short <zulcss@ubuntu.com> Sat, 27 Aug 2011 18:10:55 +0000
536+
537 net-snmp (5.4.3~dfsg-2.3) unstable; urgency=low
538
539 * Non-maintainer upload.
540@@ -648,6 +1102,23 @@ net-snmp (5.4.3~dfsg-2.3) unstable; urgency=low
541
542 -- Stephen Gran <sgran@debian.org> Sat, 27 Aug 2011 09:10:09 +0000
543
544+net-snmp (5.4.3~dfsg-2.2ubuntu1) oneiric; urgency=low
545+
546+ * Resynchronise with Debian (LP: #780149). Remaining changes:
547+ - net-snmp-config: Use bash.
548+ - Removed multiuser option when calling update-rc.d.
549+ - debian/snmpd.init: LSBify the init script.
550+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in
551+ snmpcmd.1.
552+ - debian/snmpd.postinst: Source debconf before doing work.
553+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
554+ by snmp user before install/uninstall.
555+ - Add apport hook.
556+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
557+ arches.
558+
559+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 10 May 2011 06:14:05 +0100
560+
561 net-snmp (5.4.3~dfsg-2.2) unstable; urgency=high
562
563 * Non-maintainer upload.
564@@ -672,6 +1143,35 @@ net-snmp (5.4.3~dfsg-2.1) unstable; urgency=high
565
566 -- Cyril Brulebois <kibi@debian.org> Sat, 07 May 2011 12:14:26 +0200
567
568+net-snmp (5.4.3~dfsg-2ubuntu2) oneiric; urgency=low
569+
570+ * Rebuild for Perl 5.12.
571+
572+ -- Colin Watson <cjwatson@ubuntu.com> Sat, 07 May 2011 23:29:06 +0100
573+
574+net-snmp (5.4.3~dfsg-2ubuntu1) natty; urgency=low
575+
576+ * Merge from debian unstable. Remaining changes:
577+ - Set Ubuntu maintainer address.
578+ - net-snmp-config: Use bash (LP: #104738)
579+ - Removed multiuser option when calling update-rc.d (LP: #254261)
580+ - debian/snmpd.init: LSBify the init script.
581+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcmd.1
582+ (LP: #250459)
583+ - debian/snmpd.postinst: source debconf before doing work. (LP: #589056)
584+ - debian/snmp.preinst, debian/snmp.prerm: kill any/all processes owned by
585+ snmp user before install/uninstall (LP: #573391)
586+ - Add apport hook (LP: #533603):
587+ - debian/control: Build-depends on dh-apport.
588+ - debian/rules:
589+ + Add --with apport.
590+ + override_dh_apport to install hook on snmpd package only.
591+ - debian/patches/ubntu-fix-lp-58728.patch: Fix row creation for 64bit
592+ arches. (LP: #587828)
593+ - Fix build failures with ld --no-add-needed.
594+
595+ -- Chuck Short <zulcss@ubuntu.com> Thu, 06 Jan 2011 00:35:28 +0000
596+
597 net-snmp (5.4.3~dfsg-2) unstable; urgency=high
598
599 * Add libperl-dev to libsnmp-dev dependencies (Closes: #608794)
600@@ -681,6 +1181,55 @@ net-snmp (5.4.3~dfsg-2) unstable; urgency=high
601
602 -- Jochen Friedrich <jochen@scram.de> Wed, 05 Jan 2011 13:03:32 +0100
603
604+net-snmp (5.4.3~dfsg-1ubuntu5) natty; urgency=low
605+
606+ * Fix build failure with ld --no-add-needed.
607+
608+ -- Matthias Klose <doko@ubuntu.com> Fri, 03 Dec 2010 23:45:33 +0000
609+
610+net-snmp (5.4.3~dfsg-1ubuntu4) natty; urgency=low
611+
612+ * Rebuild to add support for python 2.7.
613+
614+ -- Matthias Klose <doko@ubuntu.com> Fri, 03 Dec 2010 00:05:05 +0000
615+
616+net-snmp (5.4.3~dfsg-1ubuntu3) maverick; urgency=low
617+
618+ * debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit arches.
619+ (LP: #587828)
620+
621+ -- Chuck Short <zulcss@ubuntu.com> Wed, 25 Aug 2010 10:18:45 -0400
622+
623+net-snmp (5.4.3~dfsg-1ubuntu2) maverick; urgency=low
624+
625+ * No-change rebuild against current debhelper to drop sizable upstream
626+ changelog.
627+
628+ -- Martin Pitt <martin.pitt@ubuntu.com> Mon, 02 Aug 2010 08:34:07 +0200
629+
630+net-snmp (5.4.3~dfsg-1ubuntu1) maverick; urgency=low
631+
632+ * Merge from debian unstable. Remaining changes:
633+ - Set Ubuntu maintainer address.
634+ - net-snmp-config: Use bash. (LP: #104738)
635+ - Removed multiuser option when calling update-rc.d. (LP: #254261)
636+ - debian/snmpd.init: LSBify the init script.
637+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcmd.1
638+ (LP: #250459)
639+ - debian/snmpd.postinst: source debconf before doing work, LP: #589056
640+ - debian/snmp.preinst, debian/snmp.prerm: kill any/all processes owned by
641+ snmp user before install/uninstall, LP: #573391
642+ - Add apport hook (LP: #533603):
643+ - debian/{snmp,snmpd}.apport: Added.
644+ - debian/control: Build-depends on dh-apport.
645+ - debian/rules:
646+ + Add --with apport.
647+ + override_dh_apport to install hook on snmpd package only.
648+ * Dropped patches:
649+ - debian/patches/99-fix-ubuntu-div0.patch: Fix dvision by zero..
650+
651+ -- Chuck Short <zulcss@ubuntu.com> Mon, 28 Jun 2010 14:59:36 -0400
652+
653 net-snmp (5.4.3~dfsg-1) unstable; urgency=low
654
655 * New upstream version (Closes: #559109)
656@@ -738,6 +1287,73 @@ net-snmp (5.4.2.1~dfsg-4) unstable; urgency=low
657
658 -- Jochen Friedrich <jochen@scram.de> Tue, 01 Dec 2009 18:40:38 +0100
659
660+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu4) maverick; urgency=low
661+
662+ * debian/snmpd.postinst: source debconf before doing work, LP: #589056
663+ * debian/snmp.preinst, debian/snmp.prerm: kill any/all processes owned by
664+ snmp user before install/uninstall, LP: #573391
665+
666+ -- Dustin Kirkland <kirkland@ubuntu.com> Tue, 22 Jun 2010 14:04:48 -0500
667+
668+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu3) maverick; urgency=low
669+
670+ * SECURITY UPDATE: access restriction bypass
671+ - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516801
672+ - http://net-snmp.svn.sourceforge.net/viewvc/net-snmp?view=rev&revision=17367
673+ - CVE-2008-6123
674+
675+ -- Corey Wright <undefined@pobox.com> Mon, 31 May 2010 00:00:29 -0500
676+
677+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu2) lucid; urgency=low
678+
679+ * Add apport hook (LP: #533603):
680+ - debian/{snmp,snmpd}.apport: Added.
681+ - debian/control: Build-depends on dh-apport.
682+ - debian/rules:
683+ + Add --with apport.
684+ + override_dh_apport to install hook on snmpd package only.
685+
686+ -- Andres Rodriguez <andreserl@ubuntu.com> Sun, 28 Mar 2010 00:25:13 -0400
687+
688+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu1) lucid; urgency=low
689+
690+ * Repackage upstream tarball to re-add the MIBs: even if they are not
691+ modifiable (which is questionable), this is not a reason to keep them
692+ out of Ubuntu main.
693+ * Revert the changes to prompt about MIB downloads.
694+ * Call dh_installinit correctly to avoid installing links in rc[06].d
695+ * Temporarily re-add postinst snippet to clean up rc[06].d links left by
696+ the previous upload.
697+ * Fix egg name listed in debian/rules, apparently needed to fix another
698+ build failure.
699+
700+ -- Steve Langasek <steve.langasek@ubuntu.com> Sat, 12 Dec 2009 00:05:34 -0800
701+
702+net-snmp (5.4.2.1~dfsg-3ubuntu2) lucid; urgency=low
703+
704+ * Fix FTBFS.
705+
706+ -- Chuck Short <zulcss@ubuntu.com> Thu, 26 Nov 2009 13:20:26 -0500
707+
708+net-snmp (5.4.2.1~dfsg-3ubuntu1) lucid; urgency=low
709+
710+ * Merge from debian testing. Remaining changes:
711+ - Set Ubuntu maintainer address.
712+ - net-snmp-config: Use bash. (LP: #104738)
713+ - Removed multiuser option when calling update-rc.d. (LP: #254261)
714+ - debian/snmpd.init: LSBify the init script.
715+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcmd.1
716+ (LP: #250459)
717+ - debian/patches/99-fix-ubuntu-div0.patch: Fix dvision by zero.
718+ (LP: #426813).
719+ * Dropped patches:
720+ - debian/patches/101-fix-ipalias.patch: Applied upstream.
721+ - debian/patches/99-fix-net-snmp-syslog.patch: Applied upstream.
722+ - debian/patches/99-fix-perl-counter-in-subagent.patch: Applied upstream.
723+ - ebian/patches/103-fix-ubuntu-lmsensors.patch: No longer needed.
724+
725+ -- Chuck Short <zulcss@ubuntu.com> Thu, 26 Nov 2009 01:27:00 +0000
726+
727 net-snmp (5.4.2.1~dfsg-3) unstable; urgency=low
728
729 * Fix typo in NEWS.
730@@ -802,6 +1418,67 @@ net-snmp (5.4.2.1~dfsg-1) unstable; urgency=low
731
732 -- Jochen Friedrich <jochen@scram.de> Mon, 09 Nov 2009 18:29:10 +0100
733
734+net-snmp (5.4.1~dfsg-12ubuntu7) karmic; urgency=low
735+
736+ * debian/patches/99-fix-ubuntu-div0.patch: Fix division by zero.
737+ (LP: #426813).
738+
739+ -- Chuck Short <zulcss@ubuntu.com> Mon, 28 Sep 2009 14:02:16 -0400
740+
741+net-snmp (5.4.1~dfsg-12ubuntu6) karmic; urgency=low
742+
743+ * debian/patches/101-fix-ipalias.patch : Fix flooding syslog -
744+ Syslog fills with hundreds of these errors if you have a network
745+ interface, e.g. eth2, with no IP address, but you have an alias,
746+ e.g. eth2:1, that does have an IP address (and netmask).
747+ (LP: #270713)
748+ * debian/patches/103-fix-ubuntu-lmsensors.patch: Point to the right
749+ place for /etc/sensors3.conf. (LP: #192745)
750+
751+ -- Chuck Short <zulcss@ubuntu.com> Mon, 14 Sep 2009 12:19:41 -0400
752+
753+net-snmp (5.4.1~dfsg-12ubuntu5) karmic; urgency=low
754+
755+ * debian/patches/99-fix-perl-counter-in-subagent.patch: Fix for Counter64 in
756+ perl subagent. (LP: #406171)
757+
758+ -- Chuck Short <zulcss@ubuntu.com> Fri, 04 Sep 2009 12:10:01 -0500
759+
760+net-snmp (5.4.1~dfsg-12ubuntu4) karmic; urgency=low
761+
762+ * debian/patches/99-fix-net-snmp-syslog.patch: Fixes "invalid syslog facility".
763+ (LP: #369577)
764+
765+ -- Chuck Short <zulcss@ubuntu.com> Wed, 24 Jun 2009 14:44:51 -0400
766+
767+net-snmp (5.4.1~dfsg-12ubuntu3) jaunty; urgency=low
768+
769+ * No-change rebuild to fix lpia shared library dependencies.
770+
771+ -- Colin Watson <cjwatson@ubuntu.com> Thu, 19 Mar 2009 13:00:18 +0000
772+
773+net-snmp (5.4.1~dfsg-12ubuntu2) jaunty; urgency=low
774+
775+ * Python 2.6 transition, debian/rules (LP: #338556):
776+ - Include /usr/share/python/python.mk.
777+ - Use py_sitename and py_setup_install_args macros to install all python
778+ stuffs in the right places (/usr/lib/python*/*-packages/) and rebuild.
779+
780+ -- Alessio Treglia <quadrispro@ubuntu.com> Thu, 12 Mar 2009 00:38:57 +0100
781+
782+net-snmp (5.4.1~dfsg-12ubuntu1) jaunty; urgency=low
783+
784+ * Merge from debian unstable, remaining changes:
785+ - Set Ubuntu maintainer address.
786+ - net-snmp-config: Use bash. LP: #104738)
787+ * Removed multiuser option when calling update-rc.d (LP: #254261).
788+ * debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcd.1
789+ (LP: #250459)
790+ * debian/snmp.init: LSBify the snmpd.init script. Add status notification,
791+ based on initial patch by Gary Coady. (LP: #43575)
792+
793+ -- Chuck Short <zulcss@ubuntu.com> Wed, 17 Dec 2008 00:58:14 +0000
794+
795 net-snmp (5.4.1~dfsg-12) unstable; urgency=high
796
797 * Urgency high because of RC bug fix.
798@@ -812,6 +1489,21 @@ net-snmp (5.4.1~dfsg-12) unstable; urgency=high
799
800 -- Jochen Friedrich <jochen@scram.de> Tue, 16 Dec 2008 15:29:28 +0100
801
802+net-snmp (5.4.1~dfsg-11ubuntu1) jaunty; urgency=low
803+
804+ * Merge from debian unstable, remaining changes:
805+ - Set Ubuntu maintainer address.
806+ - net-snmp-config. Use bash (LP: #104738)
807+ * Removed multiuser option when calling update-rc.d (LP: #254261).
808+ * debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcd.1
809+ (LP: #250459)
810+ * debian/snmp.init: LSBify the snmpd.init script. Add status notification,
811+ based on inital patch by Gary Coady. (LP: #43575)
812+ * Dropped debian/patches/51_CVE-2008-0960.patch: Use debian's instead.
813+ * Dropped debian/patches/54_fix_registration_error.patch: Use debian's instead.
814+
815+ -- Chuck Short <zulcss@ubuntu.com> Wed, 05 Nov 2008 02:59:05 +0000
816+
817 net-snmp (5.4.1~dfsg-11) unstable; urgency=high
818
819 * This update fixes the following security issue:
820@@ -859,6 +1551,69 @@ net-snmp (5.4.1~dfsg-8) unstable; urgency=low
821
822 -- Jochen Friedrich <jochen@scram.de> Tue, 03 Jun 2008 13:06:57 +0200
823
824+net-snmp (5.4.1~dfsg-7.1ubuntu6) intrepid; urgency=low
825+
826+ * debian/snmpd.init: Fix snmpd script error. (LP: #270961)
827+
828+ -- Chuck Short <zulcss@ubuntu.com> Mon, 22 Sep 2008 14:18:08 -0400
829+
830+net-snmp (5.4.1~dfsg-7.1ubuntu5) intrepid; urgency=low
831+
832+ * debian/snmpd.init: LSBify the snmpd.init script. And add status
833+ notification, based on inital patch by Gary Coady. (LP: #43575)
834+ * debian/patches/54_fix_registration_error.patch: Surpresses annoying
835+ registrations in startup. (LP: #200614)
836+
837+ -- Chuck Short <zulcss@ubuntu.com> Fri, 12 Sep 2008 13:21:40 -0400
838+
839+net-snmp (5.4.1~dfsg-7.1ubuntu4) intrepid; urgency=low
840+
841+ * Fix lsb headers in init script: stop in single user mode
842+ (LP: #254261).
843+
844+ -- Mathias Gug <mathiaz@ubuntu.com> Thu, 21 Aug 2008 23:07:59 -0400
845+
846+net-snmp (5.4.1~dfsg-7.1ubuntu3) intrepid; urgency=low
847+
848+ [ Salvatore Palma ]
849+ * Add 52_fix_snmpcmd_1_typo.patch patch to adjust a typo in
850+ snmpcmd.1 (LP: #250459).
851+
852+ [ Mathias Gug ]
853+ * Remove multiuser option when calling update-rc.d. (LP: #254261).
854+
855+ -- Mathias Gug <mathiaz@ubuntu.com> Tue, 12 Aug 2008 23:03:05 -0400
856+
857+net-snmp (5.4.1~dfsg-7.1ubuntu2) intrepid; urgency=low
858+
859+ * SECURITY UPDATE: HMAC authentication spoofing.
860+ * debian/patches/51_CVE-2008-0960.patch: fixes HMAC authentication spoofing.
861+ * debian/patches/52_use_right_config_file.patch: Use the right configuration
862+ file for lmsensors. (LP: #192745)
863+
864+ -- Chuck Short <zulcss@ubuntu.com> Mon, 16 Jun 2008 15:47:18 +0000
865+
866+net-snmp (5.4.1~dfsg-7.1ubuntu1) intrepid; urgency=low
867+
868+ * Merge from debian unstable, remaining changes:
869+ - Set Ubuntu maintainer address.
870+ - net-snmp-config: Use bash. LP: #104738.
871+ - Add missing Replaces: libsnmp9-dev (<< 5.4~dfsg) to
872+ libsnmp-base to avoid file confict on dapper->hardy upgrades.
873+ (LP: #203610)
874+
875+ -- Chuck Short <zulcss@ubuntu.com> Tue, 27 May 2008 13:06:56 -0500
876+
877+net-snmp (5.4.1~dfsg-7.1) unstable; urgency=high
878+
879+ * Non-maintainer upload by the Security Team.
880+ * Fix buffer overflow in the python and perl module (__snprint_value
881+ function)that can be exploited via large OCTETSTRING in an
882+ attribute value pair (AVP) leading to arbitrary code
883+ execution (CVE-2008-2292; Closes: #482333).
884+
885+ -- Nico Golde <nion@debian.org> Sat, 24 May 2008 13:12:16 +0200
886+
887 net-snmp (5.4.1~dfsg-7) unstable; urgency=low
888
889 * Add some more Conflicts: and Replaces: magic to allow moving
890@@ -894,6 +1649,41 @@ net-snmp (5.4.1~dfsg-5) unstable; urgency=low
891
892 -- Jochen Friedrich <jochen@scram.de> Fri, 28 Dec 2007 12:43:21 +0100
893
894+net-snmp (5.4.1~dfsg-4ubuntu4) hardy; urgency=low
895+
896+ * Add missing Replaces: libsnmp9-dev (<< 5.4~dfsg) to
897+ libsnmp-base to avoid file confict on dapper->hardy upgrades
898+ (LP: #203610)
899+
900+ -- Michael Vogt <michael.vogt@ubuntu.com> Tue, 18 Mar 2008 17:47:13 +0100
901+
902+net-snmp (5.4.1~dfsg-4ubuntu3) hardy; urgency=low
903+
904+ * Rebuild with recent python-central.
905+ * Set Ubuntu maintainer address.
906+
907+ -- Matthias Klose <doko@ubuntu.com> Mon, 10 Mar 2008 12:46:06 +0000
908+
909+net-snmp (5.4.1~dfsg-4ubuntu2) hardy; urgency=low
910+
911+ * net-snmp-config: Use bash. LP: #104738.
912+
913+ -- Matthias Klose <doko@ubuntu.com> Wed, 06 Feb 2008 14:45:12 +0000
914+
915+net-snmp (5.4.1~dfsg-4ubuntu1) hardy; urgency=low
916+
917+ * Merge from debian unstable.
918+ * Remaining Ubuntu changes:
919+ - Remove stop links from rc0 and rc6
920+ - Munge Maintainer field as per spec.
921+ * Ubuntu changes dropped:
922+ - Symlink common files between the packages, CDBS ought to handle that
923+ for us automatically.
924+ * The latest Debian changes has dropped history from the changelog. Slot in
925+ the Ubuntu changes as best I can.
926+
927+ -- Steve Kowalik <stevenk@ubuntu.com> Sat, 08 Dec 2007 14:59:50 +1100
928+
929 net-snmp (5.4.1~dfsg-4) unstable; urgency=low
930
931 * Do it right this time.
932@@ -981,6 +1771,30 @@ net-snmp (5.4~dfsg-1) experimental; urgency=low
933
934 -- Jochen Friedrich <jochen@scram.de> Fri, 13 Apr 2007 16:16:02 +0200
935
936+net-snmp (5.3.1-6ubuntu2) gutsy; urgency=low
937+
938+ * Do not install the upstream changelog in libsnmp10 and libsnmp-base.
939+ * Symlink files common in libsnmp10 and libsnmp-base.
940+
941+ -- Matthias Klose <doko@ubuntu.com> Fri, 05 Oct 2007 14:55:58 +0200
942+
943+net-snmp (5.3.1-6ubuntu1) gutsy; urgency=low
944+
945+ * Merge from Debian unstable.
946+ * Remaining Ubuntu changes:
947+ - Remove stop links from rc0 and rc6
948+ - Munge Maintainer field as per spec.
949+
950+ -- Steve Kowalik <stevenk@ubuntu.com> Wed, 23 May 2007 08:58:46 +1000
951+
952+net-snmp (5.3.1-5ubuntu1) gutsy; urgency=low
953+
954+ * Merge from Debian unstable.
955+ * Remaining Ubuntu changes:
956+ - Remove stop links from rc0 and rc6
957+ * Munge Maintainer field as per spec.
958+
959+ -- Steve Kowalik <stevenk@ubuntu.com> Thu, 10 May 2007 22:20:23 +1000
960
961 net-snmp (5.3.1-3) unstable; urgency=low
962
963@@ -1037,6 +1851,19 @@ net-snmp (5.3.1-1) experimental; urgency=low
964
965 -- Jochen Friedrich <jochen@scram.de> Wed, 26 Jul 2006 12:08:46 +0200
966
967+net-snmp (5.2.3-4ubuntu1) feisty; urgency=low
968+
969+ * Merge from debian unstable, remaining changes:
970+ - remove stop links from rc0 and rc6
971+
972+ -- Scott James Remnant <scott@ubuntu.com> Tue, 28 Nov 2006 12:29:34 +0000
973+
974+net-snmp (5.2.2-5ubuntu1) edgy; urgency=low
975+
976+ * Remove stop script symlinks from rc0 and rc6.
977+
978+ -- Scott James Remnant <scott@ubuntu.com> Fri, 15 Sep 2006 17:32:44 +0100
979+
980 net-snmp (5.2.2-4) unstable; urgency=low
981
982 * Add French translation. Thanks to Thomas Huriaux
983diff --git a/debian/control b/debian/control
984index 02c87ae..523fab1 100644
985--- a/debian/control
986+++ b/debian/control
987@@ -1,7 +1,8 @@
988 Source: net-snmp
989 Section: net
990 Priority: optional
991-Maintainer: Net-SNMP Packaging Team <pkg-net-snmp-devel@lists.alioth.debian.org>
992+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
993+XSBC-Original-Maintainer: Net-SNMP Packaging Team <pkg-net-snmp-devel@lists.alioth.debian.org>
994 Uploaders: Craig Small <csmall@debian.org>,
995 Thomas Anders <tanders@users.sourceforge.net>,
996 Noah Meyerhans <noahm@debian.org>
997@@ -12,8 +13,8 @@ Build-Depends: debhelper-compat (= 12),
998 pkg-config [kfreebsd-i386 kfreebsd-amd64],
999 libbsd-dev [kfreebsd-i386 kfreebsd-amd64],
1000 libkvm-dev [kfreebsd-i386 kfreebsd-amd64],
1001- libsensors-dev [!hurd-i386 !kfreebsd-i386 !kfreebsd-amd64],
1002- default-libmysqlclient-dev, libpci-dev
1003+ libsensors4-dev [!hurd-i386 !kfreebsd-i386 !kfreebsd-amd64],
1004+ default-libmysqlclient-dev, libpci-dev, dh-apport
1005 Build-Conflicts: libsnmp-dev
1006 Standards-Version: 4.4.1
1007 Vcs-Git: https://salsa.debian.org/debian/net-snmp.git
1008diff --git a/debian/patches/HOST-MIB-Fix-a-recently-introduced-bug.patch b/debian/patches/HOST-MIB-Fix-a-recently-introduced-bug.patch
1009new file mode 100644
1010index 0000000..0e9d6fb
1011--- /dev/null
1012+++ b/debian/patches/HOST-MIB-Fix-a-recently-introduced-bug.patch
1013@@ -0,0 +1,28 @@
1014+From a0df31c18c513a0d79f4d526b1af7fad48748e57 Mon Sep 17 00:00:00 2001
1015+From: Bart Van Assche <bvanassche@acm.org>
1016+Date: Fri, 26 Jul 2019 21:40:12 -0700
1017+Subject: [PATCH] HOST-MIB: Fix a recently introduced bug
1018+
1019+Fixes: cf41e6e91015 ("HOST-MIB: Skip autofs entries")
1020+
1021+Note: this bug was not introduced by Josef but by me.
1022+---
1023+ agent/mibgroup/host/hrh_storage.c | 2 +-
1024+ 1 file changed, 1 insertion(+), 1 deletion(-)
1025+
1026+diff --git a/agent/mibgroup/host/hrh_storage.c b/agent/mibgroup/host/hrh_storage.c
1027+index 6f8ff6c53..c7c53922a 100644
1028+--- a/agent/mibgroup/host/hrh_storage.c
1029++++ b/agent/mibgroup/host/hrh_storage.c
1030+@@ -371,7 +371,7 @@ really_try_next:
1031+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1032+ Check_HR_FileSys_NFS())
1033+ return NULL;
1034+- if (Check_HR_FileSys_AutoFs())
1035++ if (HRFS_entry && Check_HR_FileSys_AutoFs())
1036+ return NULL;
1037+ if (store_idx <= NETSNMP_MEM_TYPE_MAX ) {
1038+ mem = (netsnmp_memory_info*)ptr;
1039+--
1040+2.24.0
1041+
1042diff --git a/debian/patches/HOST-MIB-Skip-autofs-entries.patch b/debian/patches/HOST-MIB-Skip-autofs-entries.patch
1043new file mode 100644
1044index 0000000..b94f2e9
1045--- /dev/null
1046+++ b/debian/patches/HOST-MIB-Skip-autofs-entries.patch
1047@@ -0,0 +1,230 @@
1048+From cf41e6e910158fb4c4cb546c49acd587c5f58232 Mon Sep 17 00:00:00 2001
1049+From: Josef Ridky <jridky@redhat.com>
1050+Date: Wed, 24 Jul 2019 07:23:47 -0700
1051+Subject: [PATCH] HOST-MIB: Skip autofs entries
1052+
1053+Do not call statfs() for autofs entries.
1054+
1055+See also https://sourceforge.net/p/net-snmp/patches/1350/.
1056+See also https://sourceforge.net/p/net-snmp/bugs/2968/.
1057+
1058+[ bvanassche: Made several small edits ]
1059+---
1060+ agent/mibgroup/hardware/fsys/fsys_mntctl.c | 8 ++++++--
1061+ agent/mibgroup/hardware/fsys/fsys_mntent.c | 11 +++++++++++
1062+ agent/mibgroup/hardware/fsys/mnttypes.h | 3 +++
1063+ agent/mibgroup/host/hr_filesys.c | 21 +++++++++++++++++++++
1064+ agent/mibgroup/host/hr_filesys.h | 1 +
1065+ agent/mibgroup/host/hr_storage.c | 5 ++++-
1066+ agent/mibgroup/host/hrh_filesys.c | 6 ++++++
1067+ agent/mibgroup/host/hrh_filesys.h | 1 +
1068+ agent/mibgroup/host/hrh_storage.c | 5 ++++-
1069+ include/net-snmp/agent/hardware/fsys.h | 1 +
1070+ 10 files changed, 58 insertions(+), 4 deletions(-)
1071+
1072+diff --git a/agent/mibgroup/hardware/fsys/fsys_mntctl.c b/agent/mibgroup/hardware/fsys/fsys_mntctl.c
1073+index e7d9a1c5a..782c8edd2 100644
1074+--- a/agent/mibgroup/hardware/fsys/fsys_mntctl.c
1075++++ b/agent/mibgroup/hardware/fsys/fsys_mntctl.c
1076+@@ -43,8 +43,9 @@ _fsys_type( int type)
1077+
1078+ case MNT_NFS:
1079+ case MNT_NFS3:
1080+- case MNT_AUTOFS:
1081+ return NETSNMP_FS_TYPE_NFS;
1082++ case MNT_AUTOFS:
1083++ return NETSNMP_FS_TYPE_AUTOFS;
1084+
1085+ /*
1086+ * The following code covers selected filesystems
1087+@@ -155,12 +156,15 @@ netsnmp_fsys_arch_load( void )
1088+ */
1089+
1090+ /*
1091+- * Optionally skip retrieving statistics for remote mounts
1092++ * Skip retrieving statistics for AUTOFS and optionally for remote
1093++ * mounts.
1094+ */
1095+ if ( (entry->flags & NETSNMP_FS_FLAG_REMOTE) &&
1096+ netsnmp_ds_get_boolean(NETSNMP_DS_APPLICATION_ID,
1097+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES))
1098+ continue;
1099++ if (entry->type == NETSNMP_FS_TYPE_AUTOFS)
1100++ continue;
1101+
1102+ if ( statfs( entry->path, &stat_buf ) < 0 ) {
1103+ snprintf( tmpbuf, sizeof(tmpbuf), "Cannot statfs %s", entry->path );
1104+diff --git a/agent/mibgroup/hardware/fsys/fsys_mntent.c b/agent/mibgroup/hardware/fsys/fsys_mntent.c
1105+index 3cdcea1fb..79e6e4f72 100644
1106+--- a/agent/mibgroup/hardware/fsys/fsys_mntent.c
1107++++ b/agent/mibgroup/hardware/fsys/fsys_mntent.c
1108+@@ -150,6 +150,13 @@ _fsys_type( char *typename )
1109+ !strcmp(typename, MNTTYPE_LOFS))
1110+ return NETSNMP_FS_TYPE_OTHER;
1111+
1112++ /* Detection of AUTOFS.
1113++ * This file system will be ignored by default
1114++ */
1115++ else if (!strcmp(typename, MNTTYPE_AUTOFS))
1116++ return NETSNMP_FS_TYPE_AUTOFS;
1117++
1118++
1119+ /*
1120+ * All other types are silently skipped
1121+ */
1122+@@ -239,6 +246,10 @@ netsnmp_fsys_arch_load( void )
1123+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES))
1124+ continue;
1125+
1126++ /* Skip AUTOFS entries */
1127++ if (entry->type == NETSNMP_FS_TYPE_AUTOFS)
1128++ continue;
1129++
1130+ #ifdef irix6
1131+ if ( NSFS_STATFS( entry->path, &stat_buf, sizeof(struct statfs), 0) < 0 )
1132+ #else
1133+diff --git a/agent/mibgroup/hardware/fsys/mnttypes.h b/agent/mibgroup/hardware/fsys/mnttypes.h
1134+index bb1b40173..53f1cc896 100644
1135+--- a/agent/mibgroup/hardware/fsys/mnttypes.h
1136++++ b/agent/mibgroup/hardware/fsys/mnttypes.h
1137+@@ -165,6 +165,9 @@
1138+ #ifndef MNTTYPE_APP
1139+ #define MNTTYPE_APP "app"
1140+ #endif
1141++#ifndef MNTTYPE_AUTOFS
1142++#define MNTTYPE_AUTOFS "autofs"
1143++#endif
1144+ #ifndef MNTTYPE_DEVPTS
1145+ #define MNTTYPE_DEVPTS "devpts"
1146+ #endif
1147+diff --git a/agent/mibgroup/host/hr_filesys.c b/agent/mibgroup/host/hr_filesys.c
1148+index 56c8b2095..8caeecf4e 100644
1149+--- a/agent/mibgroup/host/hr_filesys.c
1150++++ b/agent/mibgroup/host/hr_filesys.c
1151+@@ -834,6 +834,27 @@ Check_HR_FileSys_NFS (void)
1152+ return 0; /* no NFS file system */
1153+ }
1154+
1155++/* This function checks whether current file system is an AutoFs
1156++ * HRFS_entry must be valid prior to calling this function
1157++ * return 1 if AutoFs, 0 otherwise
1158++ */
1159++int
1160++Check_HR_FileSys_AutoFs(void)
1161++{
1162++#if HAVE_GETFSSTAT
1163++ if (HRFS_entry->HRFS_type != NULL &&
1164++#if defined(MNTTYPE_AUTOFS)
1165++ !strcmp(HRFS_entry->HRFS_type, MNTTYPE_AUTOFS)
1166++#else
1167++ !strcmp(HRFS_entry->HRFS_type, "autofs")
1168++#endif
1169++ )
1170++#endif /* HAVE_GETFSSTAT */
1171++ return 1; /* AUTOFS */
1172++
1173++ return 0; /* no AUTOFS */
1174++}
1175++
1176+ void
1177+ End_HR_FileSys(void)
1178+ {
1179+diff --git a/agent/mibgroup/host/hr_filesys.h b/agent/mibgroup/host/hr_filesys.h
1180+index 2f00355f3..36cd7dd08 100644
1181+--- a/agent/mibgroup/host/hr_filesys.h
1182++++ b/agent/mibgroup/host/hr_filesys.h
1183+@@ -10,6 +10,7 @@ extern void Init_HR_FileSys(void);
1184+ extern FindVarMethod var_hrfilesys;
1185+ extern int Get_Next_HR_FileSys(void);
1186+ extern int Check_HR_FileSys_NFS(void);
1187++extern int Check_HR_FileSys_AutoFs(void);
1188+
1189+ extern int Get_FSIndex(char *);
1190+ extern long Get_FSSize(char *); /* Temporary */
1191+diff --git a/agent/mibgroup/host/hr_storage.c b/agent/mibgroup/host/hr_storage.c
1192+index a86898451..6b459ec51 100644
1193+--- a/agent/mibgroup/host/hr_storage.c
1194++++ b/agent/mibgroup/host/hr_storage.c
1195+@@ -544,6 +544,8 @@ really_try_next:
1196+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1197+ Check_HR_FileSys_NFS())
1198+ return NULL; /* or goto try_next; */
1199++ if (Check_HR_FileSys_AutoFs())
1200++ return NULL;
1201+ if (HRFS_statfs(HRFS_entry->HRFS_mount, &stat_buf) < 0) {
1202+ snmp_log_perror(HRFS_entry->HRFS_mount);
1203+ goto try_next;
1204+@@ -683,7 +685,8 @@ Get_Next_HR_Store(void)
1205+ if (HRS_index >= 0) {
1206+ if (!(netsnmp_ds_get_boolean(NETSNMP_DS_APPLICATION_ID,
1207+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1208+- Check_HR_FileSys_NFS())) {
1209++ Check_HR_FileSys_NFS()) &&
1210++ !Check_HR_FileSys_AutoFs()) {
1211+ return HRS_index + NETSNMP_MEM_TYPE_MAX;
1212+ }
1213+ } else {
1214+diff --git a/agent/mibgroup/host/hrh_filesys.c b/agent/mibgroup/host/hrh_filesys.c
1215+index 5ad82b20f..5d2102e24 100644
1216+--- a/agent/mibgroup/host/hrh_filesys.c
1217++++ b/agent/mibgroup/host/hrh_filesys.c
1218+@@ -429,3 +429,9 @@ Check_HR_FileSys_NFS (void)
1219+ {
1220+ return (HRFS_entry->flags & NETSNMP_FS_FLAG_REMOTE) ? 1 : 0;
1221+ }
1222++
1223++int
1224++Check_HR_FileSys_AutoFs (void)
1225++{
1226++ return HRFS_entry->type == NETSNMP_FS_TYPE_AUTOFS;
1227++}
1228+diff --git a/agent/mibgroup/host/hrh_filesys.h b/agent/mibgroup/host/hrh_filesys.h
1229+index 568917e09..c0f5d6e8c 100644
1230+--- a/agent/mibgroup/host/hrh_filesys.h
1231++++ b/agent/mibgroup/host/hrh_filesys.h
1232+@@ -10,6 +10,7 @@ extern void Init_HR_FileSys(void);
1233+ extern FindVarMethod var_hrhfilesys;
1234+ extern int Get_Next_HR_FileSys(void);
1235+ extern int Check_HR_FileSys_NFS(void);
1236++extern int Check_HR_FileSys_AutoFs(void);
1237+
1238+ extern int Get_FSIndex(char *);
1239+ extern long Get_FSSize(char *); /* Temporary */
1240+diff --git a/agent/mibgroup/host/hrh_storage.c b/agent/mibgroup/host/hrh_storage.c
1241+index 810766946..6f8ff6c53 100644
1242+--- a/agent/mibgroup/host/hrh_storage.c
1243++++ b/agent/mibgroup/host/hrh_storage.c
1244+@@ -371,6 +371,8 @@ really_try_next:
1245+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1246+ Check_HR_FileSys_NFS())
1247+ return NULL;
1248++ if (Check_HR_FileSys_AutoFs())
1249++ return NULL;
1250+ if (store_idx <= NETSNMP_MEM_TYPE_MAX ) {
1251+ mem = (netsnmp_memory_info*)ptr;
1252+ }
1253+@@ -508,7 +510,8 @@ Get_Next_HR_Store(void)
1254+ if (HRS_index >= 0) {
1255+ if (!(netsnmp_ds_get_boolean(NETSNMP_DS_APPLICATION_ID,
1256+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1257+- Check_HR_FileSys_NFS())) {
1258++ Check_HR_FileSys_NFS()) &&
1259++ !Check_HR_FileSys_AutoFs()) {
1260+ return HRS_index + NETSNMP_MEM_TYPE_MAX;
1261+ }
1262+ } else {
1263+diff --git a/include/net-snmp/agent/hardware/fsys.h b/include/net-snmp/agent/hardware/fsys.h
1264+index 3f2b28440..54ab9d806 100644
1265+--- a/include/net-snmp/agent/hardware/fsys.h
1266++++ b/include/net-snmp/agent/hardware/fsys.h
1267+@@ -41,6 +41,7 @@ typedef struct netsnmp_fsys_info_s netsnmp_fsys_info;
1268+ #define NETSNMP_FS_TYPE_SYSFS (4 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)
1269+ #define NETSNMP_FS_TYPE_TMPFS (5 | _NETSNMP_FS_TYPE_LOCAL)
1270+ #define NETSNMP_FS_TYPE_USBFS (6 | _NETSNMP_FS_TYPE_LOCAL)
1271++#define NETSNMP_FS_TYPE_AUTOFS (7 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)
1272+
1273+ #define NETSNMP_FS_FLAG_ACTIVE 0x01
1274+ #define NETSNMP_FS_FLAG_REMOTE 0x02
1275+--
1276+2.24.0
1277+
1278diff --git a/debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch b/debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch
1279new file mode 100644
1280index 0000000..2469c49
1281--- /dev/null
1282+++ b/debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch
1283@@ -0,0 +1,32 @@
1284+From 9432f629e66e4f9500f6335eab3ad427f84523b2 Mon Sep 17 00:00:00 2001
1285+From: Adam Williamson <awilliam@redhat.com>
1286+Date: Thu, 20 Jul 2017 10:31:47 -0700
1287+Subject: [PATCH] Link libnetsnmptrapd against MYSQL_LIBS
1288+
1289+When building with MySQL (MariaDB) support, this library must
1290+be linked against the MySQL client library, or else it will
1291+have unresolved symbols.
1292+
1293+Origin: https://bugzilla.redhat.com/attachment.cgi?id=1301954
1294+Bug: https://sourceforge.net/p/net-snmp/bugs/2792/
1295+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886221
1296+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1814254
1297+Reviewed By: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
1298+Last-Update: 2019-12-12
1299+---
1300+ apps/Makefile.in | 2 +-
1301+ 1 file changed, 1 insertion(+), 1 deletion(-)
1302+
1303+diff --git a/apps/Makefile.in b/apps/Makefile.in
1304+index 1ea4415..e77d433 100644
1305+--- a/apps/Makefile.in
1306++++ b/apps/Makefile.in
1307+@@ -232,7 +232,7 @@ snmppcap$(EXEEXT): snmppcap.$(OSUFFIX) $(USELIBS)
1308+ $(LINK) ${CFLAGS} -o $@ snmppcap.$(OSUFFIX) ${LDFLAGS} ${LIBS} -lpcap
1309+
1310+ libnetsnmptrapd.$(LIB_EXTENSION)$(LIB_VERSION): $(LLIBTRAPD_OBJS)
1311+- $(LIB_LD_CMD) $@ ${LLIBTRAPD_OBJS} $(MIBLIB) $(USELIBS) $(PERLLDOPTS_FOR_LIBS) $(LDFLAGS)
1312++ $(LIB_LD_CMD) $@ ${LLIBTRAPD_OBJS} $(MIBLIB) $(USELIBS) $(PERLLDOPTS_FOR_LIBS) $(LDFLAGS) $(MYSQL_LIBS)
1313+ $(RANLIB) $@
1314+
1315+ snmpinforminstall:
1316diff --git a/debian/patches/fix-check-hr-filesys-autofs.patch b/debian/patches/fix-check-hr-filesys-autofs.patch
1317new file mode 100644
1318index 0000000..9751a94
1319--- /dev/null
1320+++ b/debian/patches/fix-check-hr-filesys-autofs.patch
1321@@ -0,0 +1,36 @@
1322+Description: HOST-MIB, hr_filesys: Fix Check_HR_FileSys_AutoFs()
1323+
1324+ On Linux getmntent() is available but getfsstat() not. Hence remove #if
1325+ HAVE_GETFSSTAT from around the HRFS_type check.
1326+
1327+ See also https://sourceforge.net/p/net-snmp/patches/1350/.
1328+ Fixes: cf41e6e91015 ("HOST-MIB: Skip autofs entries").
1329+Author: Bart Van Assche <bvanassche@acm.org>
1330+Origin: upstream, https://github.com/net-snmp/net-snmp/commit/bcb1a6b8afc444bbcd099a195e08f0b01cbc8f6b
1331+Bug: https://sourceforge.net/p/net-snmp/patches/1350/
1332+Bug-Ubuntu: https://launchpad.net/bugs/1843036
1333+Index: net-snmp-5.7.3+dfsg/agent/mibgroup/host/hr_filesys.c
1334+===================================================================
1335+--- net-snmp-5.7.3+dfsg.orig/agent/mibgroup/host/hr_filesys.c
1336++++ net-snmp-5.7.3+dfsg/agent/mibgroup/host/hr_filesys.c
1337+@@ -846,18 +846,8 @@ Check_HR_FileSys_NFS (void)
1338+ int
1339+ Check_HR_FileSys_AutoFs(void)
1340+ {
1341+-#if HAVE_GETFSSTAT
1342+- if (HRFS_entry->HRFS_type != NULL &&
1343+-#if defined(MNTTYPE_AUTOFS)
1344+- !strcmp(HRFS_entry->HRFS_type, MNTTYPE_AUTOFS)
1345+-#else
1346+- !strcmp(HRFS_entry->HRFS_type, "autofs")
1347+-#endif
1348+- )
1349+-#endif /* HAVE_GETFSSTAT */
1350+- return 1; /* AUTOFS */
1351+-
1352+- return 0; /* no AUTOFS */
1353++ return HRFS_entry->HRFS_type &&
1354++ strcmp(HRFS_entry->HRFS_type, MNTTYPE_AUTOFS) == 0;
1355+ }
1356+
1357+ void
1358diff --git a/debian/patches/mysql8-replace-bool.patch b/debian/patches/mysql8-replace-bool.patch
1359new file mode 100644
1360index 0000000..79a09f7
1361--- /dev/null
1362+++ b/debian/patches/mysql8-replace-bool.patch
1363@@ -0,0 +1,18 @@
1364+Description: replace my_bool with char since the former was dropped in mysql8
1365+Origin: https://sourceforge.net/p/net-snmp/code/ci/9f4af8c42d515e6b214738cc97212dfbe7f749cf/
1366+Bug: https://sourceforge.net/p/net-snmp/bugs/2922/
1367+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1814270
1368+Last-Update: 2019-02-06
1369+---
1370+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
1371+--- a/apps/snmptrapd_sql.c
1372++++ b/apps/snmptrapd_sql.c
1373+@@ -194,7 +194,7 @@ typedef struct sql_buf_t {
1374+ * static bind structures, plus 2 static buffers to bind to.
1375+ */
1376+ static MYSQL_BIND _tbind[TBIND_MAX], _vbind[VBIND_MAX];
1377+-static my_bool _no_v3;
1378++static char _no_v3;
1379+
1380+ static void _sql_process_queue(u_int dontcare, void *meeither);
1381+
1382diff --git a/debian/patches/series b/debian/patches/series
1383index 1d0cb11..8c45b55 100644
1384--- a/debian/patches/series
1385+++ b/debian/patches/series
1386@@ -31,3 +31,8 @@ snmpcmd_1_groff
1387 netsnmp_mib_api_3_groff
1388 snmplib_error_subcontainer
1389 apps_makefile_use_ldflags
1390+Link-libnetsnmptrapd-against-MYSQL_LIBS.patch
1391+mysql8-replace-bool.patch
1392+HOST-MIB-Skip-autofs-entries.patch
1393+HOST-MIB-Fix-a-recently-introduced-bug.patch
1394+fix-check-hr-filesys-autofs.patch
1395diff --git a/debian/rules b/debian/rules
1396index 181ad5c..1314ba1 100755
1397--- a/debian/rules
1398+++ b/debian/rules
1399@@ -28,7 +28,7 @@ MIB_MODULES += host
1400 endif
1401
1402 %:
1403- dh $@
1404+ dh $@ --with apport
1405
1406 # The net-snmp Makefiles cannot handle parallel builds
1407 override_dh_auto_build:
1408@@ -86,6 +86,10 @@ override_dh_fixperms-arch:
1409 chmod -x debian/libsnmp-dev/etc/snmp/*.conf
1410 chmod 600 debian/snmpd/etc/snmp/snmp*d.conf
1411
1412+.PHONY: override_dh_apport
1413+override_dh_apport:
1414+ dh_apport -psnmpd
1415+
1416 override_dh_auto_test:
1417 # prevent test since it fails with network configuration under pbuilder/etc.
1418 true
1419diff --git a/debian/source.apport b/debian/source.apport
1420new file mode 100644
1421index 0000000..867fe9e
1422--- /dev/null
1423+++ b/debian/source.apport
1424@@ -0,0 +1,36 @@
1425+#!/usr/bin/python
1426+
1427+'''apport hook for net-snmp
1428+
1429+(c) 2010 Andres Rodriguez
1430+Author: Andres Rodriguez <andreserl@ubuntu.com>
1431+
1432+This program is free software; you can redistribute it and/or modify it
1433+under the terms of the GNU General Public License as published by the
1434+Free Software Foundation; either version 2 of the License, or (at your
1435+option) any later version. See http://www.gnu.org/copyleft/gpl.html for
1436+the full text of the license.
1437+'''
1438+
1439+from apport.hookutils import *
1440+import re
1441+
1442+def add_info(report, ui):
1443+ response = ui.yesno("The contents of your /etc/snmp/snmpd.conf and "
1444+ "your /etc/snmp/snmptrapd.conf files may help "
1445+ "developers diagnose your bug more quickly. "
1446+ "However, it may contain sensitive information. "
1447+ "Do you want to include it in your bug report?")
1448+
1449+ if response == None: # user cancelled
1450+ raise StopIteration
1451+
1452+ elif response == True:
1453+ attach_conffiles(report, 'snmpd')
1454+
1455+ # get version
1456+ report['SNMPVersion'] = root_command_output(['/usr/sbin/snmpd', '-v'])
1457+
1458+ # get syslog stuff
1459+ report['SyslogSnmpd'] = recent_syslog(re.compile('snmpd\['))
1460+ report['SyslogSnmptrapd'] = recent_syslog(re.compile('snmptrapd\['))

Subscribers

People subscribed via source and target branches

to all changes: