Code review comment for lp:~rackspace-titan/glance/glance-clear-lp766295

Revision history for this message
Jay Pipes (jaypipes) wrote :

> Looks great.
>
> We don't appear to have a glance bin test on clear all. Probably some overlap
> with existing tests but we could create a test named
> 'test_add_list_clear_list' test case or something? I approve w/ or without
> this test case however.

Sure, but keep in mind clear only deletes *public* images, since it uses a call to index() and then delete()s each one in the index (which is only public images)

-jay

« Back to merge proposal