lp:~rackspace-titan/glance/glance-clear-lp766295

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~hudson-openstack/glance/trunk at revision 122

Jay Pipes (community): Approve on 2011-04-21

Dan Prince (community): Approve on 2011-04-20

Diff: 83 lines (+25/-3)

2 files modified

bin/glance (+23/-1)
tests/functional/test_bin_glance.py (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #766295: glance clear should prompt before deleting all images

Low

Fix Released

Link a bug report

Related blueprints

120. By Brian Waldon on 2011-04-20

adding --force option to test_add_clear

119. By Brian Waldon on 2011-04-19

fixing spacing in help text

118. By Brian Waldon on 2011-04-19

adding confirmation on image delete/clear; adding user_confirm functionality

117. By Eldar Nugaev on 2011-04-19

Fixing tests.
Sorry for late response.

Rick Harris wrote on 2011-04-12
Really nice job, Eldar.

> 46 + image_swift = StringIO.StringIO("nevergonnamakeit")
> 47 + options = SWIFT_OPTIONS.copy()
> 48 + del options['swift_store_user']
> 49 + self.assertRaises(BackendException,
> 50 + SwiftBackend.add,
> 51 + 2, image_swift, options)

Might be better to DRY up the code some by adding a helper-method, like:

def assertOptionRequiredForSwift(self, key):
  image_swift = StringIO.StringIO("nevergonnamakeit")
  options = SWIFT_OPTIONS.copy()
  del options[key]
  self.assertRaises(BackendException,
    SwiftBackend.add,
    2, image_swift, options)

Marking as Needs Fixing, but if you don't like the idea, I'd be willing to set this as Approved (since the suggestion is so minor :-)

116. By Thierry Carrez on 2011-04-15

Open Diablo release.

115. By Soren Hansen on 2011-04-15

Fake merge with ancient trunk. This is only so that people who "accidentally" have been following lp:~hudson-openstack/glance/trunk will not have problems updating to this.

114. By Thierry Carrez on 2011-04-14

Final versioning for Cactus

113. By Jay Pipes on 2011-04-13

Removes capture of exception from eventlet in _upload_and_activate(), which catches the exceptions that come from the _safe_kill() method properly.

Also fixes an incorrect call to _safe_kill() with mapping instead of image ID in the block of code that kills an image if a bad checksum is given.

Fixes bug #759018.

112. By Jay Pipes on 2011-04-13

Ensures that configuration values for debug and verbose are used if command-line options are not set.

111. By Eldar Nugaev on 2011-04-13

Fix logging in swift