Merge ~r00ta/maas:lp-2056781-images-sync-max-attempts into maas:master

[Jacopo Rota]

fix: lp-2056781. no maximum attempts for the download-bootresourcefile activity in the sync-bootresources workflow

The image sync process should not be stopped in case of exceptions. We should keep retrying in any case, otherwise the user would not know if the import of the images has completed successfully.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp-2056781-images-sync-max-attempts lp:~r00ta/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 29fce3c24a3880b03c6fcec9e7c8ca65e6bf8bfe

review: Approve

[Alexsander de Souza (alexsander-souza)]

+1

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b lp-2056781-images-sync-max-attempts lp:~r00ta/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/4935/console

diff --git a/src/maasserver/workflow/bootresource.py b/src/maasserver/workflow/bootresource.py
index 9d9875c..5c6528e 100644
--- a/src/maasserver/workflow/bootresource.py
+++ b/src/maasserver/workflow/bootresource.py
@@ -225,7 +225,7 @@ class DownloadBootResourceWorkflow:
             heartbeat_timeout=HEARTBEAT_TIMEOUT,
             cancellation_type=ActivityCancellationType.WAIT_CANCELLATION_COMPLETED,
             retry_policy=RetryPolicy(
-                maximum_attempts=max(2, len(input.source_list)),
+                maximum_attempts=0,  # No maximum attempts
                 maximum_interval=timedelta(seconds=60),
             ),
         )