Merge lp:~pwlars/lava-test/help into lp:lava-test/0.0
Proposed by
Paul Larson
Status: | Merged |
---|---|
Merged at revision: | 11 |
Proposed branch: | lp:~pwlars/lava-test/help |
Merge into: | lp:lava-test/0.0 |
Diff against target: |
109 lines (+51/-10) 2 files modified
abrek/builtins.py (+48/-10) abrek/command.py (+3/-0) |
To merge this branch: | bzr merge lp:~pwlars/lava-test/help |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby (community) | Approve | ||
Review via email: mp+29121@code.launchpad.net |
Description of the change
Simple help command and help provided for the existing commands
To post a comment you must log in.
36 + print getdoc(cmd)
should you use the help() function you put on cmd?
39 + except IndexError:
I would not use try/except, and just check len(argv), as the intent
is clearer, and it won't mask other issues.
I would also be happy to see some tests of at least the
infrastructure, if not the commands themselves.
Thanks,
James