Code review comment for lp:~pwlars/lava-test/help
Revision history for this message
| Paul Larson (pwlars) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> 36 + print getdoc(cmd)
>
> should you use the help() function you put on cmd?
Ah yes, fixed that
> 39 + except IndexError:
>
> I would not use try/except, and just check len(argv), as the intent
> is clearer, and it won't mask other issues.
also fixed
> I would also be happy to see some tests of at least the
> infrastructure, if not the commands themselves.
I'll add some new tests shortly