Code review comment for lp:~pwlars/lava-dispatcher/add-uboot-support

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Just two comments. I don't think we should default to beagle in the initializer. It makes it possible to omit this argument (or worse, develop on beagle all the time) and produce buggy code by accident. I would also create constants for names like beagle to make sure a simple typo will not be something hard to chase and debug. Right now it's not needed but I suspect this wil come back.

Thanks Paul
ZK

« Back to merge proposal