Merge lp:~pwlars/lava-dispatcher/add-uboot-support into lp:lava-dispatcher
Proposed by
Paul Larson
Status: | Merged |
---|---|
Merged at revision: | 3 |
Proposed branch: | lp:~pwlars/lava-dispatcher/add-uboot-support |
Merge into: | lp:lava-dispatcher |
Diff against target: |
79 lines (+53/-1) 1 file modified
lava/client.py (+53/-1) |
To merge this branch: | bzr merge lp:~pwlars/lava-dispatcher/add-uboot-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Linaro Validation Team | Pending | ||
Review via email: mp+47319@code.launchpad.net |
Description of the change
This adds support for booting to test images, and other necessary
pieces for that, such as detecting and dealing with uboot.
To post a comment you must log in.
Just two comments. I don't think we should default to beagle in the initializer. It makes it possible to omit this argument (or worse, develop on beagle all the time) and produce buggy code by accident. I would also create constants for names like beagle to make sure a simple typo will not be something hard to chase and debug. Right now it's not needed but I suspect this wil come back.
Thanks Paul
ZK