Code review comment for lp:~prsyahmi/audience/audience

Revision history for this message
Viko Adi Rahmawan (vikoadi) wrote :

hello Syahmi,
would it be better if instead of

} else if (is_subtitle (filename)) {
  if (video_player.uri != null) {
  video_player.set_subtitle_uri (filename);
  }
}

just do

} else if (is_subtitle (filename) && video_player.uri != null) {
     video_player.set_subtitle_uri (filename);
}

Thanks

« Back to merge proposal